Silence resolve errors if there were parse errors

[estebank]

Fix #74863.

In the following case:

error: missing field name before pattern
  --> $DIR/avoid-resolve-errors-caused-by-parse-error.rs:12:27
   |
LL |     if let Website { url, Some(title) } = website {
   |            -------        ^^^^^^^^^^^ this pattern needs to be preceeded by a field name
   |            |
   |            while parsing the fields for this pattern
   |
help: you might have meant to add a field
   |
LL |     if let Website { url, field_name: Some(title) } = website {
   |                           +++++++++++

we no longer emit resolution errors due to url and title not being available, and more gracefully handle when a sub-pattern is missing a field name.

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustc_ast_passes v0.0.0 (/checkout/compiler/rustc_ast_passes)
   Compiling coverage_test_macros v0.0.0 (/checkout/compiler/rustc_mir_transform/src/coverage/test_macros)
    Checking rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
    Checking rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
error[E0277]: `Cell<bool>` doesn't implement `DynSync`. Add it to `rustc_data_structures::marker` or use `IntoDynSyncSend` if it's already `Sync`
   --> compiler/rustc_middle/src/ty/context/tls.rs:98:33
    |
98  |         sync::assert_dyn_sync::<ImplicitCtxt<'_, '_>>();
    |                                 ^^^^^^^^^^^^^^^^^^^^ within `ImplicitCtxt<'_, '_>`, the trait `DynSync` is not implemented for `Cell<bool>`
note: required because it appears within the type `ParseSess`
   --> /checkout/compiler/rustc_session/src/parse.rs:194:12
    |
194 | pub struct ParseSess {
---
    |            ^^^^^^^^^^^^
note: required by a bound in `assert_dyn_sync`
   --> /checkout/compiler/rustc_data_structures/src/marker.rs:188:36
    |
188 | pub fn assert_dyn_sync<T: ?Sized + DynSync>() {}
    |                                    ^^^^^^^ required by this bound in `assert_dyn_sync`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `rustc_middle` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `rustc_middle` (lib test) due to previous error

[compiler-errors]

This seems way more flow-dependent than just checking if we've emitted any session errors.

[compiler-errors]

For example, this doesn't protect against erroneous recoveries that don't result in a bubbled up Err value.

[estebank]

Yeah, I experimented with silencing all resolve errors if there were any parse errors, but in practice it wasn't an improvement. The only place where the silencing really comes in handy is when parsing patterns fails, and the silencing should be only within that scope, not all resolve errors.

[bors]

☔ The latest upstream changes (presumably #116849) made this pull request unmergeable. Please resolve the merge conflicts.