rustdoc-search: simplify the checkTypes fast path

[notriddle]

This reduces code size while still matching the common case for plain, concrete types. This should not introduce any user-visible behavior changes.

The perf impact of the change was evaluated using https://gitlab.com/notriddle/rustdoc-js-profile. The output of the tool can be found here: http://notriddle.com/rustdoc-html-demo-5/profile-1/index.html

r? @GuillaumeGomez

[rustbot]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

[GuillaumeGomez]

Less code for same output and better performance? That's awesome! Thanks a lot for this improvement!

[GuillaumeGomez]

@bors r+ rollup

[bors]

📌 Commit 512aa5e has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit 512aa5e with merge cd05ffa...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing cd05ffa to master...

[rust-timer]

Finished benchmarking commit (cd05ffa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.6%, 2.2%]	4
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-0.5%, 2.2%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.6%]	2
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.5%, 0.4%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.809s -> 675.207s (-0.09%)
Artifact size: 313.60 MiB -> 313.64 MiB (0.01%)