Skip to content

tip for define macro name after macro_rules!#118317

Merged
bors merged 1 commit intorust-lang:masterfrom
bvanjoi:fix-118295
Dec 7, 2023
Merged

tip for define macro name after macro_rules!#118317
bors merged 1 commit intorust-lang:masterfrom
bvanjoi:fix-118295

Conversation

@bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Nov 26, 2023 •
edited
Loading

Fixes #118295

Note that there are some bad case such as macro_rules![] or macro_rules!(). However, I think these are acceptable as they are likely to be seldom used (feel free to close this if you think its shortcomings outweigh its benefits)

Edit: this problem was resolved by utilizing the source_map.span_to_next_source.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2023
petrochenkov
petrochenkov reviewed Dec 2, 2023
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
bvanjoi
bvanjoi commented Dec 3, 2023
View reviewed changes
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 3, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2023
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 4, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2023
petrochenkov
petrochenkov reviewed Dec 4, 2023
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
petrochenkov
petrochenkov reviewed Dec 5, 2023
View reviewed changes
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 6, 2023

The fix is now quite straightforward.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2023
@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 6, 2023

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Dec 6, 2023

📌 Commit 0f14e8e has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2023
@bors
Auto merge of rust-lang#118687 - matthiaskrgr:rollup-317ztgu, r=matth…
8235469 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#117981 (Remove deprecated `--check-cfg` syntax)
 - rust-lang#118177 (Suppress warnings in LLVM wrapper when targeting MSVC)
 - rust-lang#118317 (tip for define macro name after `macro_rules!`)
 - rust-lang#118504 (Enforce `must_use` on associated types and RPITITs that have a must-use trait in bounds)
 - rust-lang#118660 (rustc_arena: add `alloc_str`)
 - rust-lang#118681 (Fix is_foreign_item for StableMIR instance )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aefbbc6 into rust-lang:master Dec 7, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 7, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2023
@rust-timer
Unrolled build for rust-lang#118317
d6a436c 
Rollup merge of rust-lang#118317 - bvanjoi:fix-118295, r=petrochenkov

tip for define macro name after `macro_rules!`

Fixes rust-lang#118295

~Note that there are some bad case such as `macro_rules![]` or `macro_rules!()`. However, I think these are acceptable as they are likely to be seldom used (feel free to close this if you think its shortcomings outweigh its benefits)~

Edit: this problem was resolved by utilizing the `source_map.span_to_next_source`.

r? `@petrochenkov`
@linyihai linyihai mentioned this pull request Jul 8, 2024
Closed
@veera-sivarajan veera-sivarajan mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

Unhelpful error when macro_rules macro name is missing

4 participants

@bvanjoi @petrochenkov @bors @rustbot