make `type_flags(ReError) & HAS_ERROR` by aliemjay · Pull Request #122749 · rust-lang/rust

aliemjay · 2024-03-19T21:35:19Z

Self-explanatory. TypeVisitableExt::references_error(ReError) incorrectly returned false.

rustbot · 2024-03-19T21:35:26Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

aliemjay · 2024-03-19T21:38:18Z

compiler/rustc_borrowck/src/region_infer/opaque_types.rs

-        if let Err(guar) = arg.error_reported() {
-            return Err(guar);
-        }
-


This is removed to avoid an ICE in tests/ui/type-alias-impl-trait/under-binder.rs. I'll rewrite it anyway in #116891.

compiler-errors · 2024-03-20T01:30:30Z

tests/ui/wf/wf-in-foreign-fn-decls-issue-80468.stderr

   |                   ++++

-error: aborting due to 1 previous error
+error[E0277]: the trait bound `Ref<'_>: Trait` is not satisfied


Do you know why this error occurs?

compiler-errors

Would like some explanations for why these error messages start appearing, but I agree that this is the right approach in general. I don't think they necessarily should be fixed, but am curious nonetheless.

compiler-errors · 2024-03-20T01:31:02Z

tests/ui/type-alias-impl-trait/escaping-bound-var.stderr

   |                         ^^

-error: aborting due to 1 previous error
+error: unconstrained opaque type


And this one too, do you know why it occurs?

I'll look into it.

We don't register opaques that reference errors: https://github.com/rust-lang/rust/blame/a128516cf9de352ae1f9d430ed730363c7ca3c0c/compiler/rustc_infer/src/infer/opaque_types/mod.rs#L97.

I changed it in a later commit to register hidden types unconditionally.

tests/ui/nll/user-annotations/region-error-ice-109072.stderr

tests/ui/async-await/in-trait/unconstrained-impl-region.rs

compiler-errors · 2024-03-20T20:13:49Z

Cool, I like this consistency fix

@bors r+ rollup (only affects error code)

bors · 2024-03-20T20:13:52Z

📌 Commit 0dc006b has been approved by compiler-errors

It is now in the queue for this repository.

…rors make `type_flags(ReError) & HAS_ERROR` Self-explanatory. `TypeVisitableExt::references_error(ReError)` incorrectly returned `false`.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`) - rust-lang#122644 (pattern analysis: add a custom test harness) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122729 (Relax SeqCst ordering in standard library.) - rust-lang#122740 (use more accurate terminology) - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`) - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation) - rust-lang#122765 (Add `usize::MAX` arg tests for Vec) - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`) - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`) - rust-lang#122729 (Relax SeqCst ordering in standard library.) - rust-lang#122740 (use more accurate terminology) - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`) - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation) - rust-lang#122765 (Add `usize::MAX` arg tests for Vec) - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`) - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122749 - aliemjay:region-err, r=compiler-errors make `type_flags(ReError) & HAS_ERROR` Self-explanatory. `TypeVisitableExt::references_error(ReError)` incorrectly returned `false`.

matthiaskrgr · 2024-03-21T16:39:09Z

neat, seems to have fixed
#121006
#121807
#122098
#122549
🎉

add 2 more tests for issues fixed by rust-lang#122749 Fixes rust-lang#121807 Fixes rust-lang#122098

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121881 (std::net: adding acceptfilter feature for netbsd/freebsd.) - rust-lang#122817 (Doc Guarantee: BTree(Set|Map): `IntoIter` Iterate in Sorted by key Order) - rust-lang#122826 (Add tests for shortcomings of associated type bounds) - rust-lang#122829 (Implement `FusedIterator` for `gen` block) - rust-lang#122831 (make failure logs less verbose) - rust-lang#122837 (add test for rust-lang#122549) - rust-lang#122838 (Avoid noop rewrite of issues.txt) - rust-lang#122841 (add 2 more tests for issues fixed by rust-lang#122749) - rust-lang#122843 (Add a never type option to make diverging blocks `()`) - rust-lang#122844 (add test for ice "cannot relate region: LUB(ReErased, ReError)") - rust-lang#122845 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122841 - matthiaskrgr:moretests, r=wesleywiser add 2 more tests for issues fixed by rust-lang#122749 Fixes rust-lang#121807 Fixes rust-lang#122098

rustbot assigned petrochenkov Mar 19, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2024

aliemjay commented Mar 19, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the region-err branch from 64a5ca5 to cb4b2d1 Compare March 19, 2024 22:07

compiler-errors reviewed Mar 20, 2024

View reviewed changes

compiler-errors approved these changes Mar 20, 2024

View reviewed changes

compiler-errors assigned compiler-errors and unassigned petrochenkov Mar 20, 2024

rust-cloud-vms bot force-pushed the region-err branch from cb4b2d1 to d42e39f Compare March 20, 2024 17:26

aliemjay added 2 commits March 20, 2024 17:29

make type_flags(ReError) & HAS_ERROR

19e0ea4

register opaques that reference errors

0dc006b

rust-cloud-vms bot force-pushed the region-err branch from d42e39f to 0dc006b Compare March 20, 2024 17:30

aliemjay changed the title ~~make type_flags(ReError) | HAS_ERROR~~ make type_flags(ReError) & HAS_ERROR Mar 20, 2024

compiler-errors approved these changes Mar 20, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2024

matthiaskrgr mentioned this pull request Mar 20, 2024

Rollup of 10 pull requests #122794

Closed

jhpratt mentioned this pull request Mar 21, 2024

Rollup of 8 pull requests #122803

Merged

bors merged commit 4e792df into rust-lang:master Mar 21, 2024

rustbot added this to the 1.79.0 milestone Mar 21, 2024

compiler-errors mentioned this pull request Mar 21, 2024

Pass list of defineable opaque types into canonical queries #122077

Merged

1 task

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 22, 2024

Rollup merge of rust-lang#122841 - matthiaskrgr:moretests, r=wesleywiser

ce63d7a

add 2 more tests for issues fixed by rust-lang#122749 Fixes rust-lang#121807 Fixes rust-lang#122098

matthiaskrgr mentioned this pull request Mar 22, 2024

Rollup of 11 pull requests #122854

Merged

This was referenced Mar 22, 2024

ICE: did not expect successful goal when collecting ambiguity errors #122861

Closed

ICE: self-type Pin<&mut dyn Future> for ObjectPick never dereferenced to an object #122914

Closed

GrigorenkoPV mentioned this pull request Mar 28, 2024

ICE: assertion failed: layout.is_sized() #123154

Closed

This was referenced Apr 16, 2024

Unexpected type for constructor Struct #124004

Closed

ICE: trying to compare incompatible constructors Ref and Str(Ty("foo")) #124083

Closed

ICE: expected wide pointer extra data (e.g. slice length or trait object vtable) #124262

Closed

matthiaskrgr mentioned this pull request May 15, 2024

ICE: elem.index() < self.domain_size #125155

Closed

matthiaskrgr mentioned this pull request Jun 23, 2024

ICE: Unexpected type for 'Ref' constructor: *const &'{erased} () #126648

Closed

GrigorenkoPV mentioned this pull request Jul 6, 2024

ICE: write_immediate_to_mplace: invalid Scalar layout: with feature const_mut_refs and const_refs_to_static #127266

Closed

GrigorenkoPV mentioned this pull request Jul 15, 2024

ICE: expected wide pointer extra data (e.g. slice length or trait object vtable) #127742

Closed

nnethercote mentioned this pull request Aug 5, 2024

check type error recursively in typeck #128670

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

make `type_flags(ReError) & HAS_ERROR`#122749

make `type_flags(ReError) & HAS_ERROR`#122749
bors merged 2 commits intorust-lang:masterfrom
aliemjay:region-err

aliemjay commented Mar 19, 2024

Uh oh!

rustbot commented Mar 19, 2024

Uh oh!

aliemjay Mar 19, 2024

Uh oh!

This comment has been minimized.

compiler-errors Mar 20, 2024

Uh oh!

compiler-errors left a comment

Uh oh!

compiler-errors Mar 20, 2024

Uh oh!

aliemjay Mar 20, 2024

Uh oh!

aliemjay Mar 20, 2024

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Mar 20, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

matthiaskrgr commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

aliemjay commented Mar 19, 2024

Uh oh!

rustbot commented Mar 19, 2024

Uh oh!

aliemjay Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

compiler-errors Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

aliemjay Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

aliemjay Mar 20, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Mar 20, 2024

Uh oh!

bors commented Mar 20, 2024

Uh oh!

matthiaskrgr commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants