set_env: State the conclusion upfront #126281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People tend to skim or skip over long explanations so we should be very upfront that
set_varandremove_varare being made unsafe for a very good reason.This is just the conclusion restated almost verbatim but earlier in the docs and separated from the explanation:
rust/library/std/src/env.rs
Lines 338 to 339 in 0c96061
I think this may help with people who may not be entirely comfortable with #125937 being rejected.