Migrate `issue-64153`, `invalid-staticlib` and `no-builtins-lto` `run-make` tests to `rmake` by Oneirical · Pull Request #126437 · rust-lang/rust

Oneirical · 2024-06-13T20:38:36Z

Part of #121876 and the associated Google Summer of Code project.

try-job: x86_64-msvc

rustbot · 2024-06-13T20:38:44Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-13T20:38:46Z

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu

Thanks, looks good to me overall, just some suggestions and nits.

jieyouxu · 2024-06-16T21:22:46Z

tests/run-make/lto-avoid-object-duplication/rmake.rs

+//@ ignore-windows
+// Reason: `llvm-objdump`'s output looks different on windows than on other platforms.
+// Only checking on Unix platforms should suffice.


Remark (non-blocking): I'm not super convinced by this reasoning and it would be good to also make this test work on Windows in future improvements.

I have temporarily removed the ignore directive, maybe we could bors try it.

tests/run-make/lto-avoid-object-duplication/rmake.rs

tests/run-make/no-builtins-lto/rmake.rs

jieyouxu · 2024-06-16T21:27:43Z

@rustbot author

Oneirical · 2024-06-17T15:16:02Z

@rustbot review

jieyouxu · 2024-06-17T17:17:00Z

@bors try

tests/run-make/lto-avoid-object-duplication/rmake.rs

Migrate `issue-64153`, `invalid-staticlib` and `no-builtins-lto` `run-make` tests to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc

bors · 2024-06-17T17:18:12Z

⌛ Trying commit aa57942 with merge 2858409...

bors · 2024-06-17T19:06:05Z

💔 Test failed - checks-actions

Oneirical · 2024-06-17T19:19:15Z

Ignore restored with a FIXME, let me know if you think we should troubleshoot this right away to make it work on Windows, or leave it at that, possibly for a future "expand test compatibility" PR.

@rustbot review

jieyouxu · 2024-06-17T19:33:15Z

@Oneirical I'm okay with the ignore-windows even without a FIXME, as long as the rationale behind the ignore is documented. r=me after CI is green.

@bors delegate+

bors · 2024-06-17T19:33:18Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-06-17T20:15:01Z

@bors r=@jieyouxu

bors · 2024-06-17T20:15:03Z

📌 Commit df6d873 has been approved by jieyouxu

It is now in the queue for this repository.

Migrate `issue-64153`, `invalid-staticlib` and `no-builtins-lto` `run-make` tests to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc

Rollup of 5 pull requests Successful merges: - rust-lang#126279 (Migrate `inaccessible-temp-dir`, `output-with-hyphens` and `issue-10971-temps-dir` `run-make` tests to `rmake`) - rust-lang#126437 (Migrate `issue-64153`, `invalid-staticlib` and `no-builtins-lto` `run-make` tests to `rmake`) - rust-lang#126490 (Migrate `extern-flag-fun`, `incremental-debugger-visualiser` and `incremental-session-fail` `run-make` tests to `rmake.rs`) - rust-lang#126500 (Migrate `error-found-staticlib-instead-crate`, `output-filename-conflicts-with-directory`, `output-filename-overwrites-input`, `native-link-modifier-verbatim-rustc` and `native-link-verbatim-linker` `run-make` tests to `rmake.rs` format) - rust-lang#126534 (Migrate `run-make/comment-section` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-06-18T11:47:37Z

⌛ Testing commit df6d873 with merge af3d100...

bors · 2024-06-18T14:19:48Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing af3d100 to master...

rust-timer · 2024-06-18T18:15:00Z

Finished benchmarking commit (af3d100): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results (secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.456s -> 671.294s (-0.02%)
Artifact size: 320.48 MiB -> 319.84 MiB (-0.20%)

rustbot assigned jieyouxu Jun 13, 2024

This comment has been minimized.

Sign in to view

Kobzol mentioned this pull request Jun 13, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

Oneirical force-pushed the test-we-forget branch from 1a22be2 to 7128267 Compare June 13, 2024 20:54

This comment has been minimized.

Sign in to view

Oneirical added 2 commits June 14, 2024 10:02

rewrite and rename issue-64153 to rmake.rs

ff82e43

rewrite invalid-staticlib to rmake

cabc982

Oneirical force-pushed the test-we-forget branch from 7128267 to ea37b98 Compare June 14, 2024 14:02

This comment has been minimized.

Sign in to view

Oneirical force-pushed the test-we-forget branch from ea37b98 to 4c50d7a Compare June 14, 2024 15:12

jieyouxu approved these changes Jun 16, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024

Oneirical force-pushed the test-we-forget branch from 4c50d7a to aa57942 Compare June 17, 2024 14:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 17, 2024

jieyouxu reviewed Jun 17, 2024

View reviewed changes

tests/run-make/lto-avoid-object-duplication/rmake.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024

rewrite no-builtins-lto to rmake

df6d873

Oneirical force-pushed the test-we-forget branch from aa57942 to df6d873 Compare June 17, 2024 19:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024

jieyouxu mentioned this pull request Jun 17, 2024

Rollup of 5 pull requests #126611

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2024

bors merged commit af3d100 into rust-lang:master Jun 18, 2024

rustbot added this to the 1.81.0 milestone Jun 18, 2024

Oneirical deleted the test-we-forget branch June 18, 2024 14:51

Uh oh!

Conversation

Oneirical commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 13, 2024

Uh oh!

rustbot commented Jun 13, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jun 16, 2024

Choose a reason for hiding this comment

Uh oh!

Oneirical Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jun 16, 2024

Uh oh!

Oneirical commented Jun 17, 2024

Uh oh!

jieyouxu commented Jun 17, 2024

Uh oh!

Uh oh!

bors commented Jun 17, 2024

Uh oh!

This comment has been minimized.

bors commented Jun 17, 2024

Uh oh!

Oneirical commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jun 17, 2024

Uh oh!

bors commented Jun 17, 2024

Uh oh!

Oneirical commented Jun 17, 2024

Uh oh!

bors commented Jun 17, 2024

Uh oh!

bors commented Jun 18, 2024

Uh oh!

bors commented Jun 18, 2024

Uh oh!

rust-timer commented Jun 18, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Oneirical commented Jun 13, 2024 •

edited

Loading

Oneirical commented Jun 17, 2024 •

edited

Loading