Fixed comment and refactored functions (libstd/option.rs)#12888
Closed
aochagavia wants to merge 2 commits intorust-lang:masterfrom
aochagavia:Fix-comment
Closed
Fixed comment and refactored functions (libstd/option.rs)#12888aochagavia wants to merge 2 commits intorust-lang:masterfrom aochagavia:Fix-comment
aochagavia wants to merge 2 commits intorust-lang:masterfrom
aochagavia:Fix-comment
Conversation
The old comment did not describe the function correctly
This was referenced Mar 14, 2014
Member
Replaced match by self.as_ref() and self.as_mut()
Contributor
Author
|
Done |
bors
added a commit
that referenced
this pull request
Mar 14, 2014
The old comment of as_mut_slice() did not describe the function correctly. The new one does. Also refactored option::iter() and option::mut_iter() to use as_ref() and as_mut() instead of match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old comment of as_mut_slice() did not describe the function correctly. The new one does.
Also refactored option::iter() and option::mut_iter() to use as_ref() and as_mut() instead of match.