Report the `note` when specified in `diagnostic::on_unimplemented` by FedericoBruzzone · Pull Request #130123 · rust-lang/rust

FedericoBruzzone · 2024-09-08T23:37:21Z

Before this PR the note field was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase.

Report the note when specified in diagnostic::on_unimplemented
Added a test for unimplemented trait diagnostic
Added a test for custom unimplemented trait diagnostic

Close #130084

P.S. This is my first PR to rustc.

rustbot · 2024-09-08T23:37:28Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nadrieril (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

compiler-errors · 2024-09-09T12:55:41Z

tests/ui/traits/on-unimplemented-diagnostic.rs

@@ -0,0 +1,15 @@
+pub trait ProviderLt {}


This test doesn't really exercise anything. Could you please delete it?

compiler/rustc_hir_typeck/src/method/suggest.rs

compiler-errors · 2024-09-09T12:58:10Z

tests/ui/traits/custom-on-unimplemented-diagnostic.rs

+struct B;
+
+fn main() {
+    B.request(); //~ ERROR 15:7: 15:14: my message [E0599]


Suggested change

B.request(); //~ ERROR 15:7: 15:14: my message [E0599]

B.request();

//~^ ERROR my message

//~| LABEL my label

//~| NOTE my note

compiler-errors · 2024-09-10T20:53:54Z

compiler/rustc_hir_typeck/src/method/suggest.rs

                    ));
                }
+                for note in notes {
+                    debug!("FCB {}", note);


FCB? can you remove?

I beg your pardon, I had forgotten :'D

compiler-errors · 2024-09-10T20:54:54Z

tests/ui/traits/custom-on-unimplemented-diagnostic.rs

+fn main() {
+    B.request();
+}
+//~^^ my message [E0599]
+//~| my label
+//~| my note


Suggested change

fn main() {

B.request();

}

//~^^ my message [E0599]

//~| my label

//~| my note

fn main() {

B.request();

//~^ my message

//~| my label

//~| my note

}

Thank you. This is my first contribution, from the next I will learn best practices.

FedericoBruzzone · 2024-09-10T21:00:57Z

@compiler-errors Thank you for your review.

It should be okay now, let me know

compiler-errors · 2024-09-10T21:01:44Z

You still didn't delete the test file I asked to be deleted

Signed-off-by: FedericoBruzzone <federico.bruzzone.i@gmail.com>

FedericoBruzzone · 2024-09-10T21:07:32Z

You still didn't delete the test file I asked to be deleted

I had deleted an incorrect file

compiler-errors · 2024-09-10T22:59:33Z

@bors r+ rollup

bors · 2024-09-10T22:59:35Z

📌 Commit 4cecf42 has been approved by compiler-errors

It is now in the queue for this repository.

…r-errors Report the `note` when specified in `diagnostic::on_unimplemented` Before this PR the `note` field was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase. 1. Report the `note` when specified in `diagnostic::on_unimplemented` 2. Added a test for unimplemented trait diagnostic 3. Added a test for custom unimplemented trait diagnostic Close rust-lang#130084 P.S. This is my first PR to rustc.

…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#129260 (Don't suggest adding return type for closures with default return type) - rust-lang#129520 (Suggest the correct pattern syntax on usage of unit variant pattern for a struct variant) - rust-lang#129696 (update stdarch) - rust-lang#129759 (Stabilize `const_refs_to_static`) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#129866 (Clarify documentation labelling and definitions for std::collections) - rust-lang#130052 (Don't leave debug locations for constants sitting on the builder indefinitely) - rust-lang#130077 (Fix linking error when compiling for 32-bit watchOS) - rust-lang#130123 (Report the `note` when specified in `diagnostic::on_unimplemented`) - rust-lang#130156 (Add test for S_OBJNAME & update test for LF_BUILDINFO cl and cmd) - rust-lang#130206 (Map `WSAEDQUOT` to `ErrorKind::FilesystemQuotaExceeded`) - rust-lang#130207 (Map `ERROR_CANT_RESOLVE_FILENAME` to `ErrorKind::FilesystemLoop`) - rust-lang#130219 (Fix false positive with `missing_docs` and `#[test]`) - rust-lang#130221 (Make SearchPath::new public) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#129260 (Don't suggest adding return type for closures with default return type) - rust-lang#129520 (Suggest the correct pattern syntax on usage of unit variant pattern for a struct variant) - rust-lang#129866 (Clarify documentation labelling and definitions for std::collections) - rust-lang#130123 (Report the `note` when specified in `diagnostic::on_unimplemented`) - rust-lang#130161 (refactor merge base logic and fix `x fmt`) - rust-lang#130206 (Map `WSAEDQUOT` to `ErrorKind::FilesystemQuotaExceeded`) - rust-lang#130207 (Map `ERROR_CANT_RESOLVE_FILENAME` to `ErrorKind::FilesystemLoop`) - rust-lang#130219 (Fix false positive with `missing_docs` and `#[test]`) - rust-lang#130221 (Make SearchPath::new public) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130123 - FedericoBruzzone:master, r=compiler-errors Report the `note` when specified in `diagnostic::on_unimplemented` Before this PR the `note` field was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase. 1. Report the `note` when specified in `diagnostic::on_unimplemented` 2. Added a test for unimplemented trait diagnostic 3. Added a test for custom unimplemented trait diagnostic Close rust-lang#130084 P.S. This is my first PR to rustc.

rustbot assigned Nadrieril Sep 8, 2024

This comment has been minimized.

Sign in to view

compiler-errors assigned compiler-errors and unassigned Nadrieril Sep 9, 2024

compiler-errors suggested changes Sep 9, 2024

View reviewed changes

compiler-errors reviewed Sep 9, 2024

View reviewed changes

FedericoBruzzone force-pushed the master branch from 7ffb12d to 5168584 Compare September 10, 2024 20:43

compiler-errors reviewed Sep 10, 2024

View reviewed changes

FedericoBruzzone force-pushed the master branch 2 times, most recently from b8ce945 to 252f8ec Compare September 10, 2024 20:59

Report the note when specified in diagnostic::on_unimplemented

4cecf42

Signed-off-by: FedericoBruzzone <federico.bruzzone.i@gmail.com>

FedericoBruzzone force-pushed the master branch from 252f8ec to 4cecf42 Compare September 10, 2024 21:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2024

workingjubilee mentioned this pull request Sep 11, 2024

Rollup of 14 pull requests #130230

Closed

matthiaskrgr mentioned this pull request Sep 11, 2024

Rollup of 9 pull requests #130237

Merged

bors merged commit 5107ff4 into rust-lang:master Sep 11, 2024

rustbot added this to the 1.83.0 milestone Sep 11, 2024

-    B.request(); //~ ERROR 15:7: 15:14: my message [E0599]
+    B.request();
+    //~^ ERROR my message
+    //~| LABEL my label
+    //~| NOTE my note

Uh oh!

Conversation

FedericoBruzzone commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 8, 2024

Uh oh!

This comment has been minimized.

compiler-errors Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

compiler-errors Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

FedericoBruzzone Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

FedericoBruzzone Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

FedericoBruzzone commented Sep 10, 2024

Uh oh!

compiler-errors commented Sep 10, 2024

Uh oh!

FedericoBruzzone commented Sep 10, 2024

Uh oh!

compiler-errors commented Sep 10, 2024

Uh oh!

bors commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

FedericoBruzzone commented Sep 8, 2024 •

edited

Loading