Ban combination of GCE and new solver#130787
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 25, 2024
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
@bors r+ yeah seems good to give clear expectations that the feature isnt even implemented under the new solver lol |
Collaborator
bors
added
S-waiting-on-bors
Member
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130549 (Add RISC-V vxworks targets) - rust-lang#130595 (Initial std library support for NuttX) - rust-lang#130734 (Fix: ices on virtual-function-elimination about principal trait) - rust-lang#130787 (Ban combination of GCE and new solver) - rust-lang#130809 (Update llvm triple for OpenHarmony targets) - rust-lang#130810 (Don't trap into the debugger on panics under Linux) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
Rollup merge of rust-lang#130787 - compiler-errors:next-solver-gce, r=BoxyUwU Ban combination of GCE and new solver These do not work together. I don't want anyone to have the impression that they do. I reused the conflicting features diagnostic but I guess I could make it more tailored to the new solver? OTOH I don't really about the presentation of diagnostics here; these are nightly features after all. r? `@BoxyUwU` thoughts on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These do not work together. I don't want anyone to have the impression that they do.
I reused the conflicting features diagnostic but I guess I could make it more tailored to the new solver? OTOH I don't really about the presentation of diagnostics here; these are nightly features after all.
r? @BoxyUwU thoughts on this?