Rename slice::take... methods to split_off...
#136555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
Contributor
|
Discussion for reference https://hackmd.io/xLRjfOA4Twy3_nEzXv7gcQ#nominated-rusttf62280-Tracking-issue-for-slice_take. I'll take a look soon. |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
This was referenced Feb 5, 2025
thaliaarchi
reviewed
Feb 6, 2025
| /// | ||
| /// This is a helper function for `take` and `take_mut` that returns | ||
| /// the direction of the split (front or back) as well as the index at | ||
| /// which to split. Returns `None` if the split index would overflow. |
Contributor
There was a problem hiding this comment.
Btw, you missed the take and take_mut in this comment (not able to be shown in the snippet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename was discussed and recommended in a recent t-libs meeting.
cc #62280
There's an additional commit here which modifies internals of unstable
OneSidedRangeAPIs in order to implementsplit_offmethods in a panic-free way (removeunreachable!()) as recommended in https://github.com/rust-lang/rust/pull/88502/files#r760177240. I can split this out into a separate PR if needed.