add a flag to codegen fn attrs for foreign items by jdonszelmann · Pull Request #145855 · rust-lang/rust

jdonszelmann · 2025-08-25T16:54:42Z

r? @ghost

rustbot · 2025-08-25T16:54:47Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

jdonszelmann · 2025-08-25T16:56:02Z

@bors try @rust-timer queue

…=<try> add a flag to codegen fn attrs for foreign items

jdonszelmann · 2025-08-25T17:11:25Z

@bors try cancel

rust-bors · 2025-08-25T17:11:27Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/17215285297

rustbot · 2025-08-25T17:12:49Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

jdonszelmann · 2025-08-25T17:13:49Z

@bors try @rust-timer queue

…=<try> add a flag to codegen fn attrs for foreign items

src/tools/miri/src/helpers.rs

rust-bors · 2025-08-25T19:30:57Z

☀️ Try build successful (CI)
Build commit: e115067 (e115067424950f234cd5e5d3eef9c9b39d627e61, parent: b779120cad2c93e53c0dfb7007c1214b2b275183)

rust-timer · 2025-08-26T00:01:20Z

Finished benchmarking commit (e115067): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.3%]	6
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.2%]	3
All ❌✅ (primary)	-0.4%	[-0.5%, -0.3%]	6

Max RSS (memory usage)

Results (primary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	8
Regressions ❌ (secondary)	0.7%	[0.7%, 0.7%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	8

Bootstrap: 467.387s -> 468.157s (0.16%)
Artifact size: 378.40 MiB -> 378.37 MiB (-0.01%)

jdonszelmann · 2025-08-26T05:29:19Z

Well, that seems to have mostly gone and done it. Neat!

jdonszelmann · 2025-08-26T07:01:22Z

r? @bjorn3 alrighty, I think this resolves the standing issues. lovely!

bjorn3 · 2025-08-26T09:20:19Z

src/tools/miri/src/helpers.rs

-                        Some(adt.did()) == self.ecx.tcx.lang_items().unsafe_cell_type(),
+                    ty::Adt(adt, _) => {
+                        Some(adt.did()) == self.ecx.tcx.lang_items().unsafe_cell_type()
+                    }


Here and below please revert the reformatting. Miri has different formatting rules.

bjorn3

r=me with miri formatting changes reverted

View changes since this review

bjorn3 · 2025-08-26T11:20:47Z

@bors r+

bors · 2025-08-26T11:20:50Z

📌 Commit d66ca53 has been approved by bjorn3

It is now in the queue for this repository.

…=bjorn3 add a flag to codegen fn attrs for foreign items r? `@ghost`

bors · 2025-08-26T11:37:07Z

⌛ Testing commit d66ca53 with merge dee2538...

rust-log-analyzer · 2025-08-26T12:02:07Z

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

checking C++ file formatting
spellcheck files
building external tool typos from package typos-cli@1.34.0
finished building tool typos
npm ERR! code E429
npm ERR! 429 Too Many Requests - GET https://registry.npmjs.org/zod/-/zod-3.23.8.tgz

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-08-26T11_46_24_284Z-debug-0.log
tidy error: IO error: npm install returned exit code exit status: 1
npm install did not exit successfully
some tidy checks failed
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1583:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1225:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:18:10
  local time: Tue Aug 26 12:01:55 UTC 2025
  network time: Tue, 26 Aug 2025 12:01:55 GMT
##[error]Process completed with exit code 1.

bors · 2025-08-26T12:02:46Z

💔 Test failed - checks-actions

jieyouxu · 2025-08-26T12:14:31Z

@bors retry (tidy)

bjorn3 · 2025-08-26T12:14:42Z

@bors retry spurious npm rate limit

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2025

jdonszelmann mentioned this pull request Aug 25, 2025

Make no_mangle on foreign items explicit instead of implicit #144678

Merged