Return Option from exact_div and inherit overflow checks#147784
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 2, 2025
Merged
Return Option from exact_div and inherit overflow checks#147784bors merged 2 commits intorust-lang:masterfrom
Option from exact_div and inherit overflow checks#147784bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
r? libs-api |
rustbot
added
the
T-libs-api
dtolnay
approved these changes
Nov 2, 2025
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bd3ac03 (parent) -> 73e6c9e (this PR) Test differencesShow 4550 test diffs4550 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 73e6c9ebd9123154a196300ef58e30ec8928e74e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (73e6c9e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.434s -> 472.641s (-0.38%) |
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
…tolnay Return `Option` from `exact_div` and inherit overflow checks According to rust-lang#139911 (comment), `exact_div` should return `Option::None` if `self % rhs != 0`, panic if `rhs == 0`, and handle overflow conditionally (panic in debug, wrap in release). rust-lang#147771 should rename `exact_div` to `div_exact`.
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
…tolnay Return `Option` from `exact_div` and inherit overflow checks According to rust-lang#139911 (comment), `exact_div` should return `Option::None` if `self % rhs != 0`, panic if `rhs == 0`, and handle overflow conditionally (panic in debug, wrap in release). rust-lang#147771 should rename `exact_div` to `div_exact`.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
…tolnay Return `Option` from `exact_div` and inherit overflow checks According to rust-lang#139911 (comment), `exact_div` should return `Option::None` if `self % rhs != 0`, panic if `rhs == 0`, and handle overflow conditionally (panic in debug, wrap in release). rust-lang#147771 should rename `exact_div` to `div_exact`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #139911 (comment),
exact_divshould returnOption::Noneifself % rhs != 0, panic ifrhs == 0, and handle overflow conditionally (panic in debug, wrap in release).#147771 should rename
exact_divtodiv_exact.