perf: removed unnecessary let for return only in layout.rs#148093
perf: removed unnecessary let for return only in layout.rs#148093bors merged 1 commit intorust-lang:masterfrom
Conversation
perf: removed unnecessary let for return only
|
This won't have any performance impact. At best it could make the code nicer to look at. |
| let align_m1 = unchecked_sub(align.as_usize(), 1); | ||
| let size_rounded_up = unchecked_add(self.size, align_m1) & !align_m1; | ||
| size_rounded_up | ||
| unchecked_add(self.size, align_m1) & !align_m1 |
There was a problem hiding this comment.
The commentary above already contains the same information as the let-for-comment-binding, so I suppose getting rid of it is fine.
|
@bors r+ rollup |
|
How about rewording the title and description? |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 292db4a (parent) -> 292be5c (this PR) Test differencesShow 11 test diffs11 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 292be5c7c05138d753bbd4b30db7a3f1a5c914f7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (292be5c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.353s -> 475.908s (-0.09%) |
perf: removed unnecessary let for return only in layout.rs perf: removed unnecessary let for return only
perf: removed unnecessary let for return only