Tweak E0599 to consolidate unsatisfied trait bound messages by JohnTitor · Pull Request #151488 · rust-lang/rust

JohnTitor · 2026-01-22T12:10:39Z

estebank

Only one nitpick I'd like addressed, but r=me with or without it.

estebank · 2026-01-25T21:22:16Z

compiler/rustc_hir_typeck/src/method/suggest.rs

+            if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) =
+                predicate.kind().skip_binder()
+            {
+                let self_ty = pred.trait_ref.self_ty();
+                if self_ty.peel_refs() != rcvr_ty {
+                    continue;
+                }


This could be

Suggested change

if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) =

predicate.kind().skip_binder()

{

let self_ty = pred.trait_ref.self_ty();

if self_ty.peel_refs() != rcvr_ty {

continue;

}

if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) =

predicate.kind().skip_binder()

&& let self_ty = pred.trait_ref.self_ty()

&& self_ty.peel_refs() != rcvr_ty

{

Just slightly shorter.

I should've caught in a self-review 😓
Addressed via 44042cc

estebank · 2026-01-25T21:23:01Z

compiler/rustc_hir_typeck/src/method/suggest.rs

+    fn has_ref_dupes(&self) -> bool {
+        self.has_ref_dupes
+    }
+
+    fn into_trait_def_ids(self) -> FxIndexSet<DefId> {
+        self.trait_def_ids
+    }


In general I haven't found these kind of accessor methods to be needed, but they are not wrong. :)

(Don't change)

estebank · 2026-01-25T21:25:44Z

compiler/rustc_hir_typeck/src/method/suggest.rs

+        let mut missing_trait_names = tracker
+            .into_trait_def_ids()
+            .into_iter()
+            .map(|def_id| format!("`{}`", self.tcx.def_path_str(def_id)))


This has the only issue of not being shortened type paths. Dealing with them might make the logic harder (because the shortened types might actually look the same)...

Fair enough! I've given it some thoughts and one of the solutions would be 1) emitting shortened paths for most cases, 2) if conflicted (i.e. we have the same name in missing_trait_names), falling back to the full path. But this logic might be complicated as you said, and the later note "the traits ... must be implemented" should help users understand what it is. So I'd go for the current style.
But I'm happy to follow-up later if you have a different thought here.

estebank · 2026-01-25T21:32:27Z

tests/ui/proc-macro/quote/not-repeatable.stderr

 LL | struct Ipv4Addr;
-   | --------------- method `quote_into_iter` not found for this struct because it doesn't satisfy `Ipv4Addr: Iterator`, `Ipv4Addr: ToTokens`, `Ipv4Addr: proc_macro::ext::RepIteratorExt` or `Ipv4Addr: proc_macro::ext::RepToTokensExt`
+   | ---------------
+   | |
+   | method `quote_into_iter` not found for this struct
+   | `Ipv4Addr` doesn't implement `Iterator` or `ToTokens`


I would like it if we could still perform the label dedup and merge them to read "method quote_into_iter not found for this struct because Ipv4Addr doesn't implement Iterator or ToTokens". Would you mind spending the time trying to do that? We can land without that, but I'd rather we kept the output short when making a PR that shortens output :D

Yeah, addressed via 44042cc

estebank · 2026-01-28T17:15:25Z

r=me after squashing and dealing with the rustdoc error.

rustbot · 2026-01-29T08:26:39Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JohnTitor · 2026-01-29T08:27:57Z

Thanks! Squashed.
The CI failure should be spurious as it happens on other PRs but I'll r=you once CI passes, just in case,

JohnTitor · 2026-01-29T11:07:53Z

@bors r=estebank

rust-bors · 2026-01-29T11:07:57Z

📌 Commit 4b22ee9 has been approved by estebank

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #151775 (Portable SIMD subtree update) - #151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - #149823 (fix(parser): Disallow CR in frontmatter ) - #151475 (add foregin type tests for issue 64458) - #151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)

@estebank

Rollup merge of #151488 - JohnTitor:issue-114430, r=estebank Tweak E0599 to consolidate unsatisfied trait bound messages Fixes #114430 r? @estebank

Rollup of 5 pull requests Successful merges: - rust-lang/rust#151775 (Portable SIMD subtree update) - rust-lang/rust#151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - rust-lang/rust#149823 (fix(parser): Disallow CR in frontmatter ) - rust-lang/rust#151475 (add foregin type tests for issue 64458) - rust-lang/rust#151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)

rustbot assigned estebank Jan 22, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2026

estebank approved these changes Jan 25, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

JohnTitor force-pushed the issue-114430 branch from 44042cc to 4e3c7cd Compare January 29, 2026 08:26

Tweak E0599 to consolidate unsatisfied trait bound messages

4b22ee9

JohnTitor force-pushed the issue-114430 branch from 4e3c7cd to 4b22ee9 Compare January 29, 2026 08:26

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026

Zalathar mentioned this pull request Jan 29, 2026

Rollup of 5 pull requests #151816

Merged

rust-bors bot merged commit 2b899b0 into rust-lang:main Jan 29, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Jan 29, 2026

rust-timer added a commit that referenced this pull request Jan 29, 2026

Unrolled build for #151488

12cc716

Rollup merge of #151488 - JohnTitor:issue-114430, r=estebank Tweak E0599 to consolidate unsatisfied trait bound messages Fixes #114430 r? @estebank

github-actions bot mentioned this pull request Jan 30, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Uh oh!

Conversation

JohnTitor commented Jan 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estebank left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

estebank Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

JohnTitor Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

estebank Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

estebank Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

JohnTitor Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

estebank Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

JohnTitor Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

estebank commented Jan 28, 2026

Uh oh!

rustbot commented Jan 29, 2026

Uh oh!

JohnTitor commented Jan 29, 2026

Uh oh!

JohnTitor commented Jan 29, 2026

Uh oh!

rust-bors bot commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JohnTitor commented Jan 22, 2026 •

edited by rustbot

Loading

estebank left a comment •

edited by rustbot

Loading