Repository navigation
Use 2 parallel frontend threads by default on the nightly and dev channel - #162848
Conversation
|
CI fails due to UI tests, they should be compiled with |
|
Wasn't there some flag that reordered the diagnostics, or made compiletest to compare them in an order agnostic way? If at all possible, I think that it would be better if we actually ran (at least most) UI tests under the parallel frontend. |
We do run them, on the
Yeah, but that's not enough for some tests, and those tests are disabled with |
|
Can't we solve blessing by forcing 1 frontend thread when |
|
I'd rather keep the things as is, it's just good to have precise snapshot testing running on something reproducible. |
|
I don't want to block this PR on that, but I find it a bit concerning that we aren't testing a bunch of nightly stuff on our CI. We already don't test the next trait solver, and now we also wouldn't be testing the parallel frontend, even though both would be enabled on nightly. I'm happy to do the compiletest/bootstrap work to enable running the parallel frontend everywhere. Do you want that to be the default eventually (and perhaps have a separate one-off job that runs things sequentially, like we have the parallel job today)? |
For ui tests ( |
|
If there are enough CI resources we could also run rustc twice on every ui test - once in the default mode (if it's parallel) and once in single-threaded mode for precise
So this ^^^ would mean limiting the precise |
|
Maybe I misunderstood how the current tooling works. I thought that:
|
This is correct.
I think that we do still need them, at least while the single-threaded compiler is the default. |
Although that infra currently compares the output on per-line basis, not on per-diagnostic, so technically the diagnostics can be interspersed and messed up entirely, and the check will still pass. |
dbe31dc to
dc90826
Compare
This comment has been minimized.
This comment has been minimized.
3003fd9 to
77bff57
Compare
This comment has been minimized.
This comment has been minimized.
|
Interesting. The |
Rollup merge of #165676 - aerooneqq:make-proxy-weak-reference-in-helper-thread, r=petrochenkov Make `Proxy` weak reference as it seems that it is not dropped at all Split from #165506 which makes `Proxy` droppable, which locally fixes the issue: ```rust thread 'jobserver::jobserver_and_j' (126990) panicked at src/tools/cargo/tests/testsuite/jobserver.rs:411:10: ---- expected: tests/testsuite/jobserver.rs:405:27 ++++ actual: stderr 1 1 | [WARNING] a `-j` argument was passed to Cargo but Cargo is also configured with an external jobserver in its environment, ignoring the `-j` parameter 2 2 | [COMPILING] foo v0.0.1 ([ROOT]/foo) 3 3 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s 4 + make[1]: INTERNAL: Exiting with 1 jobserver tokens available; should be 2! ``` (see #162848 (comment)). r? @petrochenkov
|
#165854 has merged, we can try once again, it should fix jobserver tests. |
|
@bors try jobs=* nolimit |
This comment has been minimized.
This comment has been minimized.
…r=<try> Use 2 parallel frontend threads by default on the nightly and dev channel try-job: * try-nolimit
|
@rustbot ready |
|
Assuming it's ok to land this now from the infra point of view. |
|
It's not ideal w.r.t. the testing story, but also not very different from what we are doing with the next trait solver and Polonius. So let's see how it goes. |
…r=petrochenkov Use 2 parallel frontend threads by default on the nightly and dev channel Part of https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Enabling.20the.20parallel.20frontend.20by.20default.20on.20nightly/with/624597688. UI tests will still use one frontend thread by default. CC @petrochenkov
This comment has been minimized.
This comment has been minimized.
|
@bors yield |
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #165918. |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 80196be (parent) -> 6ca2b34 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6ca2b34602bf2f3591ffa7359c166b6409a44b0a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (6ca2b34): comparison URL. Overall result: no relevant changes - BENCHMARK(S) FAILED@rustbot label: -perf-regression ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ cc @rust-lang/wg-compiler-performance Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.761s -> 468.104s (-4.42%) |
|
Funnily enough, this looks like a coincidence. Looks like the ARM machine was restarted just before this PR, and its perf event config got lost (I thought I resolved this already, grr). |
|
Since this landed, a bunch of stuff has been encountering weird assertion failures in LLVM. I don't have any specific evidence that this change is responsible, but given the timing it feels like a plausible suspect. |
View all comments
Part of https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Enabling.20the.20parallel.20frontend.20by.20default.20on.20nightly/with/624597688.
UI tests will still use one frontend thread by default.
CC @petrochenkov