Repository navigation
Use getrandom instead of /scheme/rand on Redox OS - #165104
Conversation
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
cc @jackpot51 |
This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
8e3d7dc to
23d352a
Compare
|
Forgot to update the docs. Fixed now. |
|
Hm. I feel having 8 entries with "arc4random_buf" is not particular easy to read or understand, so I'm not sure the docs are coherently structured here anyways, but I appreciate your update to them nonetheless! @bors r+ |
That's very intentional, they all link to their respective documentation, which may mention individual system-specific caveats. |
…ubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
…ubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
…uwer Rollup of 14 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #165079 (Remove GenericArgRef) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165130 and may need to be recreated if the pending build succeeds.
…uwer Rollup of 14 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #165079 (Remove GenericArgRef) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165130 and may need to be recreated if the pending build succeeds.
…uwer Rollup of 14 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #165079 (Remove GenericArgRef) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165130 and may need to be recreated if the pending build succeeds.
…ubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
…ubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
…uwer Rollup of 21 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name)
…ubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165148 (ci: increase free disk space on macos-26 jobs) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name) > [!WARNING] > This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165148 (ci: increase free disk space on macos-26 jobs) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name) > [!WARNING] > This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165148 (ci: increase free disk space on macos-26 jobs) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) Failed merges: - #164981 (Reflection add TypeId::name) > [!WARNING] > This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
…uwer Rollup of 22 pull requests Successful merges: - #164851 (Add behavior tests for `Arc` and `Rc`) - #164989 (rustdoc: Fix performance regression for private documented items) - #165079 (Remove GenericArgRef) - #161781 (Don't emit InlineAsm terminator if input operand is `!`.) - #162754 (optimize large elements for slice rotating) - #163252 (Remove windows-targets dependency from the root workspace) - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - #165104 (Use getrandom instead of /scheme/rand on Redox OS) - #165132 (Implement `advance_back_by` on `Fuse`) - #165142 (Remove the unused generic Graphviz writer) - #165233 (Remove test-aarch64-apple-* jobs temporarily) - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - #163802 (fix RegionEq direction in canonical query responses) - #163986 (omit unconditionally invoking crate level limits query) - #164920 (Point at prior token on `let` when expression is expected) - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - #165114 (use native interpreter impl for funnel shifts intrinsics) - #165119 (remove unnecessary fast path from borrowck) - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - #165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
Rollup merge of #165104 - bjorn3:redox_getrandom, r=workingjubilee Use getrandom instead of /scheme/rand on Redox OS This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (c9cf70b): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Artifact size: 406.61 MiB -> 406.74 MiB (0.03%) |
…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#164851 (Add behavior tests for `Arc` and `Rc`) - rust-lang/rust#164989 (rustdoc: Fix performance regression for private documented items) - rust-lang/rust#165079 (Remove GenericArgRef) - rust-lang/rust#161781 (Don't emit InlineAsm terminator if input operand is `!`.) - rust-lang/rust#162754 (optimize large elements for slice rotating) - rust-lang/rust#163252 (Remove windows-targets dependency from the root workspace) - rust-lang/rust#163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - rust-lang/rust#165104 (Use getrandom instead of /scheme/rand on Redox OS) - rust-lang/rust#165132 (Implement `advance_back_by` on `Fuse`) - rust-lang/rust#165142 (Remove the unused generic Graphviz writer) - rust-lang/rust#165233 (Remove test-aarch64-apple-* jobs temporarily) - rust-lang/rust#163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - rust-lang/rust#163802 (fix RegionEq direction in canonical query responses) - rust-lang/rust#163986 (omit unconditionally invoking crate level limits query) - rust-lang/rust#164920 (Point at prior token on `let` when expression is expected) - rust-lang/rust#164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - rust-lang/rust#165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - rust-lang/rust#165114 (use native interpreter impl for funnel shifts intrinsics) - rust-lang/rust#165119 (remove unnecessary fast path from borrowck) - rust-lang/rust#165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - rust-lang/rust#165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - rust-lang/rust#165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
|
@rustbot label: +perf-regression-triaged |
…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#164851 (Add behavior tests for `Arc` and `Rc`) - rust-lang/rust#164989 (rustdoc: Fix performance regression for private documented items) - rust-lang/rust#165079 (Remove GenericArgRef) - rust-lang/rust#161781 (Don't emit InlineAsm terminator if input operand is `!`.) - rust-lang/rust#162754 (optimize large elements for slice rotating) - rust-lang/rust#163252 (Remove windows-targets dependency from the root workspace) - rust-lang/rust#163839 (Fix the floating point clobbers of RISC-V `clobber_abi`) - rust-lang/rust#165104 (Use getrandom instead of /scheme/rand on Redox OS) - rust-lang/rust#165132 (Implement `advance_back_by` on `Fuse`) - rust-lang/rust#165142 (Remove the unused generic Graphviz writer) - rust-lang/rust#165233 (Remove test-aarch64-apple-* jobs temporarily) - rust-lang/rust#163371 (Don't suggest replacing foreign format specifiers in `concat!` output) - rust-lang/rust#163802 (fix RegionEq direction in canonical query responses) - rust-lang/rust#163986 (omit unconditionally invoking crate level limits query) - rust-lang/rust#164920 (Point at prior token on `let` when expression is expected) - rust-lang/rust#164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop) - rust-lang/rust#165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols) - rust-lang/rust#165114 (use native interpreter impl for funnel shifts intrinsics) - rust-lang/rust#165119 (remove unnecessary fast path from borrowck) - rust-lang/rust#165122 (fix MaybeDangling validity logic for ZST at usize::MAX) - rust-lang/rust#165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`) - rust-lang/rust#165129 (Fix ICE in prelude edition lint) > [!WARNING] > This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.