Skip to content

make improper_ctypes accept ppcf128 - #165274

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:ppcf128-improper-ctypes
Nov 8, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:ppcf128-improper-ctypes

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

tracking issue: #163323

It is represented as an ADT, so needs custom logic to be accepted. The point of this type is that it's compatible with its C counterpart, so the lint definitely should accept it.

r? compiler

It is represented as an ADT, so needs custom logic to be accepted
@folkertdev folkertdev added the F-c_longdouble `#![feature(c_longdouble)]` label Nov 1, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 1, 2026

@tiif tiif left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b18288d has been approved by tiif

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #165274 (make `improper_ctypes` accept `ppcf128`)
 - #165580 (cg_llvm: Use an invariant lifetime brand for LLVM types)
 - #165628 (Fix `Command` Debug docs about non-utf8 data)
 - #165630 (Fix ICE on `Reborrow` impls with erroneous field types)
@rust-bors
rust-bors Bot merged commit 67ee673 into rust-lang:main Nov 8, 2026
14 checks passed
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup merge of #165274 - folkertdev:ppcf128-improper-ctypes, r=tiif

make `improper_ctypes` accept `ppcf128`

tracking issue: #163323

It is represented as an ADT, so needs custom logic to be accepted. The point of this type is that it's compatible with its C counterpart, so the lint definitely should accept it.

r? compiler
@rustbot rustbot added this to the 1.102.0 milestone Nov 8, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2026
…, r=beetrees

make improper_ctypes accept `x87_f80`

tracking issue: rust-lang#163982

Like rust-lang#165274, but for `x87_f80`.

It is represented as an ADT, so needs custom logic to be accepted. The point of this type is that it's compatible with its C counterpart, so the lint definitely should accept it.

r? beetrees
rust-bors Bot pushed a commit that referenced this pull request Nov 11, 2026
Rollup merge of #165779 - folkertdev:x87_f80-improper-ctypes, r=beetrees

make improper_ctypes accept `x87_f80`

tracking issue: #163982

Like #165274, but for `x87_f80`.

It is represented as an ADT, so needs custom logic to be accepted. The point of this type is that it's compatible with its C counterpart, so the lint definitely should accept it.

r? beetrees
mehmettoplu-rs pushed a commit to mehmettoplu-rs/miri that referenced this pull request Nov 13, 2026
make improper_ctypes accept `x87_f80`

tracking issue: rust-lang/rust#163982

Like rust-lang/rust#165274, but for `x87_f80`.

It is represented as an ADT, so needs custom logic to be accepted. The point of this type is that it's compatible with its C counterpart, so the lint definitely should accept it.

r? beetrees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-c_longdouble `#![feature(c_longdouble)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants