Skip to content

OIDC artifact pushes - #165609

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Mark-Simulacrum:oidc
Nov 8, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Mark-Simulacrum:oidc

Conversation

@Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

View all comments

This implements the r-l/r side of rust-lang/simpleinfra#1305.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 7, 2026
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2026
@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 9cfd76f failed: CI. Failed job:

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 8659f7a failed: CI. Failed jobs:

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for aa1c4cc failed: CI. Failed jobs:

@Mark-Simulacrum
Mark-Simulacrum force-pushed the oidc branch 2 times, most recently from cefe763 to 7c648cd Compare November 7, 2026 19:13
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1,dist-i586-gnu*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
OIDC artifact pushes


try-job: dist-various-1
try-job: dist-i586-gnu*
@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 86f9162 (86f9162a4fde3bd39730dbe34fb605400b003926)
Base parent: 9358362 (93583629f7429a9ab9fb807408e66eed81f3e5b1)

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

r? @Kobzol

As far as I can tell, this should be fully working at this point.

@rustbot

rustbot commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, otherwise you can r=me.

I think that the github.event_name thing should always work only for pushes, but that is a separate topic.

View changes since this review

Comment thread .github/workflows/ci.yml
if-no-files-found: ignore
retention-days: 5

- name: assume intermediate artifact role

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a comment here (or to rustc-dev-guide, but that would be a bit more annoying) that explains what this two-step role thing does?

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@Kobzol pushed a commit with a comment. Does it make sense to you, or is there anything missing in the explanation that we should include?

@Kobzol

Kobzol commented Nov 7, 2026

Copy link
Copy Markdown
Member

Looks good, thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c7634e4 has been tentatively approved by Kobzol

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup of 8 pull requests

Successful merges:

 - #164720 (Expand E0271 on return type)
 - #165301 (Fix struct-literal suggestion spans in macros)
 - #165573 ([tiny] Tweak incorrect `#[default]` errors)
 - #164036 ([rustdoc] Allow `.` to be used the same as `::` in the search)
 - #165457 (tests: llvm 24 can merge addrspace declarations again)
 - #165462 (Use `emit_ptr_va_arg` for `va_arg` on AVR)
 - #165609 (OIDC artifact pushes)
 - #165620 (change return type of FloatErrorKind::kind)
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup of 8 pull requests

Successful merges:

 - #164720 (Expand E0271 on return type)
 - #165301 (Fix struct-literal suggestion spans in macros)
 - #165573 ([tiny] Tweak incorrect `#[default]` errors)
 - #164036 ([rustdoc] Allow `.` to be used the same as `::` in the search)
 - #165457 (tests: llvm 24 can merge addrspace declarations again)
 - #165462 (Use `emit_ptr_va_arg` for `va_arg` on AVR)
 - #165609 (OIDC artifact pushes)
 - #165620 (change return type of FloatErrorKind::kind)
@rust-bors
rust-bors Bot merged commit f35d81c into rust-lang:main Nov 8, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup merge of #165609 - Mark-Simulacrum:oidc, r=Kobzol

OIDC artifact pushes

This implements the r-l/r side of rust-lang/simpleinfra#1305.
@Mark-Simulacrum
Mark-Simulacrum deleted the oidc branch November 8, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants