Repository navigation
Rollup of 7 pull requests - #165659
Rollup of 7 pull requests#165659
Conversation
Slice the byte vector before converting to str, avoiding a whole-buffer conversion while compaction may leave invalid UTF-8.
This variant is never constructed.
For `yield` this is not a problem, as nobody uses droppable types a coroutine resume argument. For `inline_asm`, it is delicate to gauge the effect.
Document and correct assignment order for yield and inline-asm The first two commits cleanup and rename the variants of `InitKind`. The third commit attempts to make several parts of MIR analyses a bit more consistent. For calls, we correctly model assignments to happen on the return edge. For yields, assignments also happen on the return edge according to dataflow analyses (see `TerminatorEdges`), but were considered unconditional. This should not change anything, as nobody uses droppable types as coroutine resume argument. For `inline_asm`, same thing, dataflow analyses consider assignments to happen on `targets` and not on unwind. This is also corrected. I have no idea what's the impact of this. I suppose user wisely avoid to assign droppable types in inline asm that may unwind.
Ensure all output is printed from lldb debugger tester Finally tracked down this down =) This solves 2 issues: 1. some commands, especially `script` commands, would not have their output printed by lldb batchmode. This is apparently because `SBCommandReturnObject.HasResult()` only checks if there is an output *value*, and `script` does not "return" a value. We now also check if there is anything in the output file handle (`SBCommandReturnObject.GetOutputSize()`), and if so, we print it. 2. I noticed in at least one PR, the `copy this to bless` output was cut off. We now make sure to flush all of the output handles. ~~Setting `lldb.debugger.SetAsync(False)` and explicitly flushing the stdout/stderr both individually fixed the issue from what I could tell, but doing both is preferable since we didn't want async mode on anyway.~~ r? @Kobzol, @jieyouxu
…Mark-Simulacrum std: fix build on RTEMS after libc 0.2.191 libc 0.2.191 changed newlib's `stat` on RTEMS to use `st_atim`/`st_mtim`/`st_ctim` timespecs, so std stopped compiling for armv7-rtems-eabihf. This reads the timestamps from the timespec fields, which also gives RTEMS real nanosecond values instead of 0. I also added RTEMS to the `ReadDir::dir` fallback list: libc has no `dirfd` for it, and the other `dirfd` cfg lists in that file already skip RTEMS. Checked with `cargo check -Zbuild-std --target armv7-rtems-eabihf`. Fixes rust-lang#164719
… r=Mark-Simulacrum String::retain: convert only the untouched UTF-8 tail During compaction, `String::retain` reads the next character with `g.s.get_unchecked(read..len)`. This invokes `String`’s `Deref`, constructing a `&str` over the entire `0..len` buffer before selecting the unread tail. For example, removing `'é'` from `"éab"` and moving `'a'` left changes the buffer from `C3 A9 61 62` to `61 A9 61 62`. The next iteration reads the valid `'b'` tail, but first converts the entire buffer, including the orphaned `A9` continuation byte, to `&str`. Constructing a non-UTF-8 `&str` is not immediate language-level UB under the [Reference’s validity requirements](https://doc.rust-lang.org/reference/behavior-considered-undefined.html). However, this conversion violates [`from_utf8_unchecked`’s documented safety precondition](https://doc.rust-lang.org/std/str/fn.from_utf8_unchecked.html#safety). The libs discussion in rust-lang#134598 is discussing which operations accept invalid UTF-8; `str::get_unchecked` is absent from the tentative list. The fix slices `read..len` directly from the byte vector and converts only that untouched tail to `&str`. The original string was valid UTF-8, and `read` remains on a character boundary. rust-lang#154583 uses the same approach for `extract_if`. Related: rust-lang#150067, rust-lang#134598, rust-lang#154583.
…ibute, r=Mark-Simulacrum Add Documentation for the `crate_type` attribute Add documentation for the `crate_type` attribute <!-- homu-ignore:start --> Briefly introduces how the attribute works, possible errors and necessary details when using the attribute. Part of rust-lang#157604
…r=mejrs Fix unused attribute duplication for lint attributes r? @mejrs
…hen_send, r=maxdexh oneshot_multi_task_recv_then_send test: wait for test thread to finish This currently sometimes fails in Miri under nextest as the background thread does not get enough time to finish before the test is done. (It's not a problem with the normal test runner as that runs all tests together in one big Miri invocation so the test does have more than enough time.)
|
@bors r+ p=5 force |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1a4d65f (parent) -> 5b7b37a (this PR) Test differencesShow 416 test diffs416 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5b7b37aefcb5b2fba3c2392bc9065b9e4602d494 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
parent commit: 1a4d65fa9d In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
|
Finished benchmarking commit (5b7b37a): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.9%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 483.59s -> 485.729s (0.44%) |
Successful merges:
crate_typeattribute #164519 (Add Documentation for thecrate_typeattribute)r? @ghost
Create a similar rollup