Repository navigation
Avoid repeated gated spans snapshots during macro matching - #165663
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Avoid repeated gated spans snapshots during macro matching
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (811ea5e): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @bors rollup=iffy rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (primary -1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 483.59s -> 484.603s (0.21%) |
|
Nice! @bors r+ |
…uwer Rollup of 9 pull requests Successful merges: - #165161 (`rustc_builtin_macros` cleanup, part 9) - #165663 (Avoid repeated gated spans snapshots during macro matching) - #165637 (library: std: process: Make Command::status platform specific) - #163571 ([rustdoc] Render `Deref` methods on aliased items) - #164712 (Reject unexpanded attributes in attributes) - #165516 (Point at array length instead of whole array type) - #165674 (Add regression test for issue 118449) - #165676 (Make `Proxy` weak reference as it seems that it is not dropped at all) - #165695 (Add regression test for unsafe diagnostic attributes)
Rollup merge of #165663 - TaKO8Ki:hoist-macro-gating-snapshot, r=nnethercote Avoid repeated gated spans snapshots during macro matching This removes unnecessary `mem::take` and `mem::swap` calls. r? nnethercote
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (713ca2a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Artifact size: 406.20 MiB -> 407.05 MiB (0.21%) |
This removes unnecessary
mem::takeandmem::swapcalls.r? nnethercote