Repository navigation
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`rustc_builtin_macros cleanup`, part 10
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (d806b54): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 4.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 488.192s -> 485.857s (-0.48%) |
This also changes the resulting `args` to be a `ThinVec<Param>` directly and avoid further reiteration.
dbc6e68 to
bb00efd
Compare
rustc_builtin_macros cleanup, part 10rustc_builtin_macros cleanup, part 10
|
I expect that this will be the second-last cleanup PR to this crate. |
|
Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs cc @ZuseZ4 Changes to the code generated for builtin derived traits. cc @nnethercote |
This PR consists of several mixed cleanups throughout the crate and a large set of changes that introduce the
MethodBodyenum so that most derive macros no longer need to interact withSubstructureat all and can just generate their method bodies directly. This allows moving the awkward fields and the distinction between "selflike" and "nonselflike" args away fromMethodDefand intoMethodBody::SubstructureFunc. It also merges theexpand_extandexpandfunctions and thus removes the annoyingfrom_scratchargument.Previous PR: #165161