Skip to content

rustc_builtin_macros cleanup, part 10 - #165892

Open
cyrgani wants to merge 15 commits into
rust-lang:mainfrom
cyrgani:builtin-macros-10
Open

cyrgani wants to merge 15 commits into
rust-lang:mainfrom
cyrgani:builtin-macros-10

Conversation

@cyrgani

@cyrgani cyrgani commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

This PR consists of several mixed cleanups throughout the crate and a large set of changes that introduce the MethodBody enum so that most derive macros no longer need to interact with Substructure at all and can just generate their method bodies directly. This allows moving the awkward fields and the distinction between "selflike" and "nonselflike" args away from MethodDef and into MethodBody::SubstructureFunc. It also merges the expand_ext and expand functions and thus removes the annoying from_scratch argument.

Previous PR: #165161

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2026
@panstromek

Copy link
Copy Markdown
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 12, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 12, 2026
`rustc_builtin_macros cleanup`, part 10
@rust-bors

rust-bors Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d806b54 (d806b546eb57a9f0b0d091d86f17c0deef34b8f0)
Base parent: 8eb778d (8eb778d04094d3af4b26580cab327e0413eb1e02)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d806b54): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.0% [2.7%, 7.7%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 7

Bootstrap: 488.192s -> 485.857s (-0.48%)
Artifact size: 406.14 MiB -> 406.17 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 13, 2026
@cyrgani cyrgani changed the title rustc_builtin_macros cleanup, part 10 rustc_builtin_macros cleanup, part 10 Nov 13, 2026
@cyrgani

cyrgani commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

I expect that this will be the second-last cleanup PR to this crate.
r? @nnethercote

@cyrgani
cyrgani marked this pull request as ready for review November 13, 2026 10:40
@rustbot

rustbot commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Changes to the code generated for builtin derived traits.

cc @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants