Skip to content

Introduce 'make doc' -> 'make docs'#28174

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:gh14705
Sep 3, 2015
Merged

Introduce 'make doc' -> 'make docs'#28174
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:gh14705

Conversation

@steveklabnik
Copy link
Copy Markdown
Contributor

Because 'doc' is a directory, when running make doc, you'll see
this:

make: Nothing to be done for `doc'.

By adding a target for doc to build docs, both work.

Fixes #14705

@rust-highfive
Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Copy Markdown
Member

Could you add this target to mk/doc.mk instead? Other than that though r=me

@steveklabnik
Copy link
Copy Markdown
Contributor Author

😓

Because 'doc' is a directory, when running `make doc`, you'll see
this:

    make: Nothing to be done for `doc'.

By adding a target for `doc` to build `docs`, both work.

Fixes rust-lang#14705
@steveklabnik
Copy link
Copy Markdown
Contributor Author

@bors: r=alexcricton

@bors
Copy link
Copy Markdown
Collaborator

bors commented Sep 3, 2015

📌 Commit 7c8c72d has been approved by alexcricton

bors added a commit that referenced this pull request Sep 3, 2015
Because 'doc' is a directory, when running `make doc`, you'll see
this:

    make: Nothing to be done for `doc'.

By adding a target for `doc` to build `docs`, both work.

Fixes #14705
@bors
Copy link
Copy Markdown
Collaborator

bors commented Sep 3, 2015

⌛ Testing commit 7c8c72d with merge 69c3b39...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants