Make unreachable_code lint warn on diverging call arguments as well

[Manishearth]

Fixes #1889

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[frewsxcv]

🎊 💃 ③⓪⓪⓪⓪ 🍸 🎊

[eddyb]

@bors r+

[bors]

📌 Commit 2eca64d has been approved by eddyb

[eefriedman]

<std macros>:4:9: 6:15 error: unreachable expression, #[deny(unreachable_code)] on by default
<std macros>:4 $ msg , {
<std macros>:5 static _FILE_LINE : ( & 'static str , u32 ) = ( file ! (  ) , line ! (  ) ) ;
<std macros>:6 & _FILE_LINE } ) } ) ; ( $ fmt : expr , $ ( $ arg : tt ) + ) => (
src/libsyntax/ext/base.rs:681:13: 683:57 note: in this expansion of panic! (defined in <std macros>)
<std macros>:4:9: 6:15 error: unreachable expression, #[deny(unreachable_code)] on by default
<std macros>:4 $ msg , {
<std macros>:5 static _FILE_LINE : ( & 'static str , u32 ) = ( file ! (  ) , line ! (  ) ) ;
<std macros>:6 & _FILE_LINE } ) } ) ; ( $ fmt : expr , $ ( $ arg : tt ) + ) => (
src/libsyntax/ext/tt/macro_rules.rs:212:17: 212:77 note: in this expansion of panic! (defined in <std macros>)
<std macros>:4:9: 6:15 error: unreachable expression, #[deny(unreachable_code)] on by default
<std macros>:4 $ msg , {
<std macros>:5 static _FILE_LINE : ( & 'static str , u32 ) = ( file ! (  ) , line ! (  ) ) ;
<std macros>:6 & _FILE_LINE } ) } ) ; ( $ fmt : expr , $ ( $ arg : tt ) + ) => (
src/libsyntax/ext/tt/macro_rules.rs:217:5: 217:84 note: in this expansion of panic! (defined in <std macros>)
error: aborting due to 3 previous errors

[eddyb]

@bors r-

[Manishearth]

Fixed. Got a full build running now.

[durka]

error: irrelevant comment lives too long

[Manishearth]

error: aborting due to previous error

(fixed)

[nrc]

@bors: r+

[bors]

📌 Commit 7fbcb51 has been approved by nrc

[bors]

⌛ Testing commit 7fbcb51 with merge 561d088...

[bors]

💔 Test failed - auto-win-msvc-64-opt

[Manishearth]

@bors retry

[bors]

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-64-x-android-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-msvc-64-opt...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt