Skip to content

doc: miscellaneous OpenOptions:append improvements#31093

Merged
bors merged 1 commit into
rust-lang:masterfrom
tshepang:misc-doc-improvements
Jan 24, 2016
Merged

doc: miscellaneous OpenOptions:append improvements#31093
bors merged 1 commit into
rust-lang:masterfrom
tshepang:misc-doc-improvements

Conversation

@tshepang
Copy link
Copy Markdown
Member

No description provided.

@rust-highfive
Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Comment thread src/libstd/fs.rs Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually sounds worse to my ear, is there any precedence anywhere?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative is "the operating system guarantees that all writes are atomic".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveklabnik
Copy link
Copy Markdown
Contributor

I like it all except that one thing.

Comment thread src/libstd/fs.rs Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe a - is needed between an adverb and the adjective it modifies ("adequately-sized" doesn't look "correct" to me, in other words). However, this kind of "multi-word adjective" -- "more than adequately sized" -- always feels a little awkward and informal to me in any case. Perhaps "with a buffer of sufficient size" or "with a sufficiently large buffer". (Also, I have no idea what a "more than adequately sized buffer" even is supposed to mean -- surely "adequate" size would be enough, since that is sort of the definition of adequate?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good points

@tshepang
Copy link
Copy Markdown
Member Author

review comments addresed

@steveklabnik
Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thank you!

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 24, 2016

📌 Commit 012d68a has been approved by steveklabnik

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 24, 2016

⌛ Testing commit 012d68a with merge 4043c02...

@bors bors merged commit 012d68a into rust-lang:master Jan 24, 2016
@tshepang tshepang deleted the misc-doc-improvements branch January 25, 2016 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants