suggest doubling recursion limit in more situations#39655
suggest doubling recursion limit in more situations#39655bors merged 2 commits intorust-lang:masterfrom
Conversation
There was a problem hiding this comment.
This duplicate error shouldn't be here and yet it is. cc #38940 @jseyfried
durka
force-pushed
the
recursion-limit-suggestion
branch
2 times, most recently
from
fbaef50 to
422b789
Compare
durka
force-pushed
the
recursion-limit-suggestion
branch
from
422b789 to
b4993ec
Compare
|
r? |
| ei.callee.name())); | ||
| err.note(&format!( | ||
| "consider adding a `#![recursion_limit=\"{}\"]` attribute to your crate", | ||
| suggested_limit)); |
There was a problem hiding this comment.
Can this be .help() too or is there a reason it can't?
There was a problem hiding this comment.
Yes, I think it can be.
There was a problem hiding this comment.
This will need update to help I think
|
Thanks. I'll |
durka
force-pushed
the
recursion-limit-suggestion
branch
from
80cd3cf to
e1773cb
Compare
src/libsyntax/ext/base.rs
Outdated
There was a problem hiding this comment.
maybe we should factor this code into some sort of helper?
There was a problem hiding this comment.
I feel like it'd also be nice to make this into an error code ("recursion limit reached") with a note giving the specific details. That way, we could give an extended error description.
There was a problem hiding this comment.
Where should I put the helper and diagnostic code? Note that the PR is split across libsyntax and librustc_typeck.
There was a problem hiding this comment.
Hmm. Can we only put diagnostic codes into rustc crates? I'm not sure.
There was a problem hiding this comment.
There are diagnostic codes in libsyntax. Can I define it there and use the same one from librustc_typeck?
There was a problem hiding this comment.
Meh. I think we should improve this, but it's not that big a deal.
|
@bors r+ |
|
📌 Commit e1773cb has been approved by |
|
⌛ Testing commit e1773cb with merge f46ed40... |
|
💔 Test failed - status-appveyor |
durka
force-pushed
the
recursion-limit-suggestion
branch
from
e1773cb to
6e259dc
Compare
|
Should be fixed. |
|
@bors r=nikomatsakis |
|
📌 Commit 6e259dc has been approved by |
|
⌛ Testing commit 6e259dc with merge 907f26d... |
…=nikomatsakis suggest doubling recursion limit in more situations Fixes rust-lang#38852. r? @bluss
|
@bors retry |
|
☀️ Test successful - status-appveyor, status-travis |
6 participants
Fixes #38852.
r? @bluss