Update the list of confusable characters#43698
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 8, 2017
Merged
Conversation
Also reorder and space the list to make it clearer for futures updates and to come closer to the original list. Thanks @est31 for the instructions. Fixes rust-lang#43629. r? @est31
ollie27
reviewed
Aug 6, 2017
| ('﹍', "Dashed Low Line", '_'), | ||
| ('﹎', "Centreline Low Line", '_'), | ||
| ('﹏', "Wavy Low Line", '_'), | ||
| ('＿', "Fullwidth Low Line", '-'), |
Contributor
Author
There was a problem hiding this comment.
Good catch.
Thanks!
Contributor
|
|
Contributor
Author
Member
|
Looks good to me but I'm not sure I should be the one r+ing it. r? @eddyb |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 5e29bb9 has been approved by |
arielb1
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
|
Wait, what? that was pointing out a typo. |
Contributor
|
Why was this merged with the typo -.- |
Contributor
Author
|
My bad, I was thinking it was a joke and didn't see the typo. |
Contributor
|
@MaloJaffre you're fine lol. I just got my panties in a twist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reorder and space the list to make it clearer for futures updates
and to come closer to the original list.
This was tedious but somewhat rewarding!
Thanks @est31 for the instructions.
Fixes #43629.
r? @est31