Merged
Conversation
Old implementation called the assembler once per crate, but we need to call it for each object file instead, because a single crate can now have more than one object file. This patch fixes issue rust-lang#45836 (Can't compile core for msp430 in release mode)
This addresses the concern of rust-lang#47316 by estimating CGU size based on the size of its MIR. Looking at the size estimate differences for a small selection of crates, this heuristic produces different orderings, which should more accurately reflect optimisation time. Fixes rust-lang#47316.
Also a little bit of clean up.
Arrays of uninhabited types were considered to also be uninhabited if their length had not been evaluated, causing unsoundness.
Unstable sort was added recently, and the code that is being modified is 3 years old. As quicksort doesn't allocate it will likely perform as well as, or better than linear search.
It turns out that this *can* happen after all, if the region is only used in projections from the input types.
Collaborator
|
⌛ Testing commit c915e3a with merge d0121328dabef6bda79acb845d233b2c3cc0dc7e... |
Member
Author
|
@bors: retry |
Collaborator
|
⌛ Testing commit c915e3a with merge cfe81f291317a8c9d6d3044cbe55fa1773004782... |
Member
Author
|
@bors: r+ |
Collaborator
|
📌 Commit 9bb1823 has been approved by |
Collaborator
|
⌛ Testing commit 9bb1823 with merge e91e190e7a65f688106f1cea6686a1b8f836d973... |
Collaborator
|
💔 Test failed - status-travis |
Member
Author
|
@bors: r+ |
Collaborator
|
📌 Commit a06d333 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jan 26, 2018
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jan 26, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-C lto=valoption #47521