Don't lint numeric overflows in promoteds in release mode by oli-obk · Pull Request #50841 · rust-lang/rust

oli-obk · 2018-05-17T17:22:20Z

mitigates #50814

eddyb · 2018-05-17T17:27:32Z

cc @nikomatsakis I don't think this is a complete solution, but is it even on the right path?

oli-obk · 2018-05-17T17:36:15Z

Repeating my statement from IRC:

This might leak memory/not run destructors.

I don't see the issue with that, because to reach this code, you have to ignore a lint (soon to be deny-by-default) in order to get here.

Yes this might be happening in a dependency, but right now you can only reach this by either doing UB (or at least very shady unsafe stuff) inside a constant or comparing addresses of constant values inside a constant.

rust-highfive · 2018-05-17T18:19:25Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:44:29] 
[00:44:29] running 1426 tests
[00:44:33] .....................................................................................i..............
[00:44:39] .............F.......F.F...F........i...............................................................
[00:44:46] ....................................................................................................
[00:44:49] ....................................................................................................
[00:44:52] ....................................................................................................
[00:44:57] ....................................................................................................
---
[00:45:33] failures:
[00:45:33] 
[00:45:33] ---- [ui] ui/const-eval/conditional_array_execution.rs stdout ----
[00:45:33]  
[00:45:33] error: test compilation failed although it shouldn't!
[00:45:33] status: exit code: 101
[00:45:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-eval/conditional_array_execution.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/conditional_array_execution/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/conditional_array_execution/auxiliary" "-A" "unused"
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] stderr:
[00:45:33] stderr:
[00:45:33] ------------------------------------------
[00:45:33] {"message":"attempt to subtract with overflow","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/conditional_array_execution.rs","byte_start":538,"byte_end":543,"line_start":15,"line_end":15,"column_start":19,"column_end":24,"is_primary":true,"text":[{"text":"const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];","highlight_start":19,"highlight_end":24}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[{"message":"#[warn(const_err)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: attempt to subtract with overflow\n  --> /checkout/src/test/ui/const-eval/conditional_array_execution.rs:15:19\n   |\nLL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];\n   |                   ^^^^^\n   |\n   = note: #[warn(const_err)] on by default\n\n"}
[00:45:33] {"message":"this constant cannot be used","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/conditional_array_execution.rs","byte_start":520,"byte_end":570,"line_start":15,"line_end":15,"column_start":1,"column_end":51,"is_primary":true,"text":[{"text":"const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];","highlight_start":1,"highlight_end":51}],"label":"attempt to subtract with overflow","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: this constant cannot be used\n  --> /checkout/src/test/ui/const-eval/conditional_array_execution.rs:15:1\n   |\nLL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize];\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempt to subtract with overflow\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/conditional_array_execution.rs","byte_start":686,"byte_end":689,"line_start":20,"line_end":20,"column_start":20,"column_end":23,"is_primary":true,"text":[{"text":"    println!(\"{}\", FOO);","highlight_start":20,"highlight_end":23}],"label":"referenced constant has errors","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/conditional_array_execution.rs:20:20\n   |\nLL |     println!(\"{}\", FOO);\n   |                    ^^^ referenced constant has errors\n\n"}
[00:45:33] {"message":"librustc_codegen_llvm/mir/operand.rs:333: use of _14 before def","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: librustc_codegen_llvm/mir/operand.rs:333: use of _14 before def\n\n"}
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:45:33] 
[00:45:33] note: the compiler unexpectedly panicked. this is a bug.
[00:45:33] 
[00:45:33] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:45:33] note: rustc 1.27.0-dev running on x86_64-unknown-linux-gnu
[00:45:33] 
[00:45:33] 
[00:45:33] note: compiler flags: -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] thread '[ui] ui/const-eval/conditional_array_execution.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] thread '[ui] ui/const-eval/conditional_array_execution.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] 
[00:45:33] ---- [ui] ui/const-eval/issue-43197.rs stdout ----
[00:45:33]  
[00:45:33] error: test compilation failed although it shouldn't!
[00:45:33] status: exit code: 101
[00:45:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-eval/issue-43197.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/issue-43197/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/issue-43197/auxiliary" "-A" "unused"
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] stderr:
[00:45:33] stderr:
[00:45:33] ------------------------------------------
[00:45:33] {"message":"attempt to subtract with overflow","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":577,"byte_end":580,"line_start":20,"line_end":20,"column_start":20,"column_end":23,"is_primary":true,"text":[{"text":"    const X: u32 = 0-1;","highlight_start":20,"highlight_end":23}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[{"message":"#[warn(const_err)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: attempt to subtract with overflow\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:20:20\n   |\nLL |     const X: u32 = 0-1;\n   |                    ^^^\n   |\n   = note: #[warn(const_err)] on by default\n\n"}
[00:45:33] {"message":"this constant cannot be used","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":562,"byte_end":581,"line_start":20,"line_end":20,"column_start":5,"column_end":24,"is_primary":true,"text":[{"text":"    const X: u32 = 0-1;","highlight_start":5,"highlight_end":24}],"label":"attempt to subtract with overflow","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: this constant cannot be used\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:20:5\n   |\nLL |     const X: u32 = 0-1;\n   |     ^^^^^^^^^^^^^^^^^^^ attempt to subtract with overflow\n\n"}
[00:45:33] {"message":"attempt to subtract with overflow","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":696,"byte_end":699,"line_start":23,"line_end":23,"column_start":24,"column_end":27,"is_primary":true,"text":[{"text":"    const Y: u32 = foo(0-1);","highlight_start":24,"highlight_end":27}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: attempt to subtract with overflow\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:23:24\n   |\nLL |     const Y: u32 = foo(0-1);\n   |                        ^^^\n\n"}
[00:45:33] {"message":"this constant cannot be used","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":677,"byte_end":701,"line_start":23,"line_end":23,"column_start":5,"column_end":29,"is_primary":true,"text":[{"text":"    const Y: u32 = foo(0-1);","highlight_start":5,"highlight_end":29}],"label":"attempt to subtract with overflow","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: this constant cannot be used\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:23:5\n   |\nLL |     const Y: u32 = foo(0-1);\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^ attempt to subtract with overflow\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":815,"byte_end":816,"line_start":26,"line_end":26,"column_start":23,"column_end":24,"is_primary":true,"text":[{"text":"    println!(\"{} {}\", X, Y);","highlight_start":23,"highlight_end":24}],"label":"referenced constant has errors","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:26:23\n   |\nLL |     println!(\"{} {}\", X, Y);\n   |                       ^ referenced constant has errors\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-43197.rs","byte_start":818,"byte_end":819,"line_start":26,"line_end":26,"column_start":26,"column_end":27,"is_primary":true,"text":[{"text":"    println!(\"{} {}\", X, Y);","highlight_start":26,"highlight_end":27}],"label":"referenced constant has errors","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/issue-43197.rs:26:26\n   |\nLL |     println!(\"{} {}\", X, Y);\n   |                          ^ referenced constant has errors\n\n"}
[00:45:33] {"message":"librustc_codegen_llvm/mir/operand.rs:333: use of _15 before def","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: librustc_codegen_llvm/mir/operand.rs:333: use of _15 before def\n\n"}
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:45:33] 
[00:45:33] note: the compiler unexpectedly panicked. this is a bug.
[00:45:33] 
[00:45:33] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:45:33] note: rustc 1.27.0-dev running on x86_64-unknown-linux-gnu
[00:45:33] 
[00:45:33] 
[00:45:33] note: compiler flags: -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] thread '[ui] ui/const-eval/issue-43197.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] thread '[ui] ui/const-eval/issue-43197.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] 
[00:45:33] ---- [ui] ui/const-eval/issue-44578.rs stdout ----
[00:45:33]  
[00:45:33] error: test compilation failed although it shouldn't!
[00:45:33] status: exit code: 101
[00:45:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-eval/issue-44578.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/issue-44578/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/issue-44578/auxiliary" "-A" "unused"
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] stderr:
[00:45:33] stderr:
[00:45:33] ------------------------------------------
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-44578.rs","byte_start":801,"byte_end":827,"line_start":35,"line_end":35,"column_start":20,"column_end":46,"is_primary":true,"text":[{"text":"    println!(\"{}\", <Bar<u16, u8> as Foo>::AMT); //~ WARN const_err","highlight_start":20,"highlight_end":46}],"label":"referenced constant has errors","suggested_replacement":null,"expansion":null}],"children":[{"message":"#[warn(const_err)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/issue-44578.rs:35:20\n   |\nLL |     println!(\"{}\", <Bar<u16, u8> as Foo>::AMT); //~ WARN const_err\n   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors\n   |\n   = note: #[warn(const_err)] on by default\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/issue-44578.rs","byte_start":801,"byte_end":827,"line_start":35,"line_end":35,"column_start":20,"column_end":46,"is_primary":true,"text":[{"text":"    println!(\"{}\", <Bar<u16, u8> as Foo>::AMT); //~ WARN const_err","highlight_start":20,"highlight_end":46}],"label":"referenced constant has errors","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/issue-44578.rs:35:20\n   |\nLL |     println!(\"{}\", <Bar<u16, u8> as Foo>::AMT); //~ WARN const_err\n   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors\n\n"}
[00:45:33] {"message":"librustc_codegen_llvm/mir/operand.rs:333: use of _14 before def","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: librustc_codegen_llvm/mir/operand.rs:333: use of _14 before def\n\n"}
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:45:33] 
[00:45:33] note: the compiler unexpectedly panicked. this is a bug.
[00:45:33] 
[00:45:33] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:45:33] note: rustc 1.27.0-dev running on x86_64-unknown-linux-gnu
[00:45:33] 
[00:45:33] 
[00:45:33] note: compiler flags: -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] thread '[ui] ui/const-eval/issue-44578.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] thread '[ui] ui/const-eval/issue-44578.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
[00:45:33] 
[00:45:33] ---- [ui] ui/const-eval/promoted_errors.rs stdout ----
[00:45:33]  
[00:45:33] error: test compilation failed although it shouldn't!
[00:45:33] status: exit code: 101
[00:45:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/const-eval/promoted_errors.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/promoted_errors/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/const-eval/promoted_errors/auxiliary" "-A" "unused"
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] stderr:
[00:45:33] stderr:
[00:45:33] ------------------------------------------
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":559,"byte_end":567,"line_start":15,"line_end":15,"column_start":14,"column_end":22,"is_primary":true,"text":[{"text":"    let _x = 0u32 - 1;","highlight_start":14,"highlight_end":22}],"label":"attempt to subtract with overflow","suggested_replacement":null,"expansion":null}],"children":[{"message":"#[warn(const_err)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:15:14\n   |\nLL |     let _x = 0u32 - 1;\n   |              ^^^^^^^^ attempt to subtract with overflow\n   |\n   = note: #[warn(const_err)] on by default\n\n"}
[00:45:33] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":612,"byte_end":619,"line_start":17,"line_end":17,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(1-1));","highlight_start":20,"highlight_end":27}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:17:20\n   |\nLL |     println!(\"{}\", 1/(1-1));\n   |                    ^^^^^^^\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":612,"byte_end":619,"line_start":17,"line_end":17,"column_start":20,"column_end":27,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(1-1));","highlight_start":20,"highlight_end":27}],"label":"attempt to divide by zero","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:17:20\n   |\nLL |     println!(\"{}\", 1/(1-1));\n   |                    ^^^^^^^ attempt to divide by zero\n\n"}
[00:45:33] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:492:22
[00:45:33] {"message":"attempt to divide by zero","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":683,"byte_end":690,"line_start":20,"line_end":20,"column_start":14,"column_end":21,"is_primary":true,"text":[{"text":"    let _x = 1/(1-1);","highlight_start":14,"highlight_end":21}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: attempt to divide by zero\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:20:14\n   |\nLL |     let _x = 1/(1-1);\n   |              ^^^^^^^\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":683,"byte_end":690,"line_start":20,"line_end":20,"column_start":14,"column_end":21,"is_primary":true,"text":[{"text":"    let _x = 1/(1-1);","highlight_start":14,"highlight_end":21}],"label":"attempt to divide by zero","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:20:14\n   |\nLL |     let _x = 1/(1-1);\n   |              ^^^^^^^ attempt to divide by zero\n\n"}
[00:45:33] {"message":"constant evaluation error","code":{"code":"const_err","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/const-eval/promoted_errors.rs","byte_start":759,"byte_end":775,"line_start":23,"line_end":23,"column_start":20,"column_end":36,"is_primary":true,"text":[{"text":"    println!(\"{}\", 1/(false as u32));","highlight_start":20,"highlight_end":36}],"label":"attempt to divide by zero","suggested_replacement":null,"expansion":null}],"children":[],"rendered":"warning: constant evaluation error\n  --> /checkout/src/test/ui/const-eval/promoted_errors.rs:23:20\n   |\nLL |     println!(\"{}\", 1/(false as u32));\n   |                    ^^^^^^^^^^^^^^^^ attempt to divide by zero\n\n"}
[00:45:33] {"message":"librustc_codegen_llvm/mir/operand.rs:333: use of _39 before def","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: librustc_codegen_llvm/mir/operand.rs:333: use of _39 before def\n\n"}
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:33] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:45:33] 
[00:45:33] note: the compiler unexpectedly panicked. this is a bug.
[00:45:33] 
[00:45:33] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:45:33] note: rustc 1.27.0-dev running on x86_64-unknown-linux-gnu
[00:45:33] 
[00:45:33] 
[00:45:33] note: compiler flags: -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[00:45:33] 
[00:45:33] ------------------------------------------
[00:45:33] 
[00:45:33] thread '[ui] ui/const-eval/promoted_errors.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3014:9
---
[00:45:33] test result: FAILED. 1415 passed; 4 failed; 7 ignored; 0 measured; 0 filtered out
[00:45:33] 
[00:45:33] 
[00:45:33] 
[00:45:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:45:33] 
[00:45:33] 
[00:45:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:45:33] Build completed unsuccessfully in 0:02:20
[00:45:33] Build completed unsuccessfully in 0:02:20
[00:45:33] Makefile:58: recipe for target 'check' failed
[00:45:33] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0b21f80f
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-05-18T07:41:48Z

Ok... so the errors that are happening here make it seem to me like this is not the way to go. This would become a very messy codegen_llvm solution.

I just left in the regression part

eddyb · 2018-05-18T08:16:39Z

@bors r+

bors · 2018-05-18T08:16:40Z

📌 Commit 2ec0421 has been approved by eddyb

rust-highfive · 2018-05-18T08:47:02Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:57:16] .................................i..................................................................
[00:57:37] .............................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:57:46] .......................................
[00:58:01] ....................................................................................................
[00:58:48] .ii..............................................................i..................................
[00:59:06] ..................i.ii...............................................test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:59:47] ..........................iiiiiii...................................................................
[01:00:04] ....................................................................................................
[01:00:19] ....................................................................................................
[01:00:36] .................................................................................................
---
Check compiletest suite=run-fail mode=run-fail (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:02:53] 
[01:02:53] running 143 tests
[01:03:03] ....................................................................................................
[01:03:08] ...........F......i........................
[01:03:08] 
[01:03:08] ---- [run-fail] run-fail/promoted_overflow.rs stdout ----
[01:03:08] 
[01:03:08] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:03:08] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:03:08] error: Error: expected failure status (Some(101)) but received status Some(0).
[01:03:08] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail/promoted_overflow/a"
[01:03:08] stdout:
[01:03:08] ------------------------------------------
[01:03:08] 
---
[01:03:08] test result: FAILED. 141 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out
[01:03:08] 
[01:03:08] 
[01:03:08] 
[01:03:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:03:08] 
[01:03:08] 
[01:03:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:03:08] Build completed unsuccessfully in 0:15:04
[01:03:08] Build completed unsuccessfully in 0:15:04
[01:03:08] Makefile:58: recipe for target 'check' failed
[01:03:08] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:25e66edf
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-05-18T13:18:40Z

@bors r=eddyb

just a test that needed adjusting

bors · 2018-05-18T13:18:40Z

📌 Commit 304ab16 has been approved by eddyb

bors · 2018-05-18T19:44:13Z

☔ The latest upstream changes (presumably #50653) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2018-05-20T09:22:19Z

@bors r=eddyb

bors · 2018-05-20T09:22:20Z

📌 Commit 8753d0f has been approved by eddyb

bors · 2018-05-20T11:13:30Z

⌛ Testing commit 8753d0f with merge 22c25dd...

@eddyb

Don't lint numeric overflows in promoteds in release mode r? @eddyb mitigates #50814

bors · 2018-05-20T13:20:58Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 22c25dd to master...

rust-highfive assigned eddyb May 17, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2018

oli-obk force-pushed the promote_errors_to_panics branch from 7f235b4 to 5b45767 Compare May 18, 2018 07:39

oli-obk changed the title ~~Promote errors to panics~~ Don't lint numeric overflows in promoteds in release mode May 18, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2018

oli-obk force-pushed the promote_errors_to_panics branch from 778b5f1 to 304ab16 Compare May 18, 2018 09:16

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2018

oli-obk added 3 commits May 19, 2018 13:10

Release mode overflows should not cause const eval to error

d81651e

Add a test showing the erroneous promoted bug

27e710f

Overflows only panic in debug mode

8753d0f

oli-obk force-pushed the promote_errors_to_panics branch from 304ab16 to 8753d0f Compare May 19, 2018 11:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2018

bors added a commit that referenced this pull request May 20, 2018

Auto merge of #50841 - oli-obk:promote_errors_to_panics, r=eddyb

22c25dd

Don't lint numeric overflows in promoteds in release mode r? @eddyb mitigates #50814

bors merged commit 8753d0f into rust-lang:master May 20, 2018

oli-obk deleted the promote_errors_to_panics branch June 15, 2020 15:26

Uh oh!

Conversation

oli-obk commented May 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb commented May 17, 2018

Uh oh!

oli-obk commented May 17, 2018

Uh oh!

rust-highfive commented May 17, 2018

Uh oh!

oli-obk commented May 18, 2018

Uh oh!

eddyb commented May 18, 2018

Uh oh!

bors commented May 18, 2018

Uh oh!

rust-highfive commented May 18, 2018

Uh oh!

oli-obk commented May 18, 2018

Uh oh!

bors commented May 18, 2018

Uh oh!

bors commented May 18, 2018

Uh oh!

oli-obk commented May 20, 2018

Uh oh!

bors commented May 20, 2018

Uh oh!

bors commented May 20, 2018

Uh oh!

bors commented May 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oli-obk commented May 17, 2018 •

edited

Loading