Closed
Conversation
Enable the tidy check to forbid this! Closes rust-lang#53006
Pointed out by nll. It is correct that the mut annotation is not needed.
A generic AArch64 target that can be used for writing bare-metal code for 64-bit ARM architectures.
Collaborator
|
📌 Commit 652dc76270157269569a579565eac26fc64dd60d has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 652dc76270157269569a579565eac26fc64dd60d with merge 572c3ea061c969b6b3656c355a83887fb44c8b22... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
removed
the
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
…ts-error, r=petrochenkov Emit error for pattern arguments in trait methods The error and check for this already existed, but the parser didn't try to parse trait method arguments as patterns, so the error was never emitted. This surfaces the error, so we get better errors than simple parse errors. This improves the error message described in rust-lang#53046.
Member
Author
Collaborator
|
📌 Commit 6dd9bcc has been approved by |
Collaborator
|
⌛ Testing commit 6dd9bcc with merge 62e16061d1c941b466ba3feafd77624e7674fe6d... |
Collaborator
|
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
Contributor
|
😭 |
Make LLVM emit assembly comments with -Z asm-comments Fixes rust-lang#35741, and makes `-Z asm-comments` actually do something useful. Before: ``` .section .text.main,"ax",@progbits .globl main .p2align 4, 0x90 .type main,@function main: .cfi_startproc pushq %rax .cfi_def_cfa_offset 16 movslq %edi, %rax leaq _ZN1t4main17he95a7d4f1843730eE(%rip), %rdi movq %rsi, (%rsp) movq %rax, %rsi movq (%rsp), %rdx callq _ZN3std2rt10lang_start17h3121da83b2bc3697E movl %eax, %ecx movl %ecx, %eax popq %rcx .cfi_def_cfa_offset 8 retq .Lfunc_end8: .size main, .Lfunc_end8-main .cfi_endproc ``` After: ``` .section .text.main,"ax",@progbits .globl main # -- Begin function main .p2align 4, 0x90 .type main,@function main: # @main .cfi_startproc pushq %rax .cfi_def_cfa_offset 16 movslq %edi, %rax leaq _ZN1t4main17he95a7d4f1843730eE(%rip), %rdi movq %rsi, (%rsp) # 8-byte Spill movq %rax, %rsi movq (%rsp), %rdx # 8-byte Reload callq _ZN3std2rt10lang_start17h3121da83b2bc3697E movl %eax, %ecx movl %ecx, %eax popq %rcx .cfi_def_cfa_offset 8 retq .Lfunc_end8: .size main, .Lfunc_end8-main .cfi_endproc # -- End function ```
…isdreavus Fix styles Fixes rust-lang#53262.
Member
Author
Collaborator
|
📌 Commit e330088 has been approved by |
Collaborator
|
⌛ Testing commit e330088 with merge 2f145628b8adc02274cf3d128bb806092ac1fe58... |
Member
|
Only 19 more to break the current record (38) of most PRs per rollup! 🎉 🎈 |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
@bors retry treeclosed- (I'm signing off now, let's allow bors to automatically determine if Travis has fixed the network issue with the rest of the queue.) |
Collaborator
|
⌛ Testing commit e330088 with merge 5d0d2e2c4ad5de98afd71e34033bf81a5f696eca... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
.swap_bytes/.reverse_bits#53240 (Add individual documentation for.swap_bytes/.reverse_bits)