Skip to content

Split the deriving code into submodules for each trait - #5434

Closed
ghost wants to merge 2 commits into
incomingfrom
unknown repository
Closed

ghost wants to merge 2 commits into
incomingfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 19, 2013

Copy link
Copy Markdown

This is the first step in refactoring the deriving code in libsyntax. No code is changed, just rearranged.

@ghost

ghost commented Mar 19, 2013

Copy link
Copy Markdown
Author

This was broken by #5426. Rebasing against incoming and running local tests now. Will post again when it's safe to try merging again.

@ghost

ghost commented Mar 19, 2013

Copy link
Copy Markdown
Author

Rebase and tests complete.

bors added a commit that referenced this pull request Mar 20, 2013
This is the first step in refactoring the deriving code in libsyntax. No code is changed, just rearranged.
@bors bors closed this Mar 20, 2013
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
rustup: update for the new Ty::walk interface.

The first commit fixes a portability bug in `setup-toolchain.sh`, while the second rewrites the handling of "trait impl methods" in `use_self` - even if `Ty::walk` could've still been used, it was IMO a misuse.

This could also serve as a PSA: *please* use `hir_ty_to_ty` instead of trying to compare `hir::Ty`s between themselves or against semantic `Ty`s. Its "quasi-deprecation" is 3 years old and doesn't really mean anything, just that it's currently uncached and that we should eventually querify it (either for a single HIR node, or for all of the nodes in an entire definition).

---

changelog: none
RalfJung added a commit to RalfJung/rust that referenced this pull request Oct 19, 2026
use errno_result in a few more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants