During rustc bootstrap, make default for optimize independent of debug#54811
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 12, 2018
Conversation
…g` setting in `Cargo.toml`.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Oct 4, 2018
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
So the cargo.toml.example says:
# Indicates that the build should be optimized for debugging Rust. Note that
# this is typically not what you want as it takes an incredibly large amount of
# time to have a debug-mode rustc compile any code (notably libstd). If this
# value is set to `true` it will affect a number of configuration options below
# as well, if unconfigured.
#debug = false
presumably this is still true, and at least one other thing is affected? (It's not very specific about the effects of setting debug = true) It feels like this text may want to be tweaked (e.g., to suggest the possibility of setting optimize = false to get better debuginfo)
r=me once cargo.toml.example is edited to @pnkfelix's satisfaction
and to briefly touch on the theory of debugging rustc versus the practice of such.
Contributor
Author
|
@bors r=nikomatsakis rollup |
Collaborator
|
📌 Commit 40e20e2 has been approved by |
bors
added
S-waiting-on-bors
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Oct 9, 2018
…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Oct 10, 2018
…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 11, 2018
…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 12, 2018
…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840
bors
added a commit
that referenced
this pull request
Oct 12, 2018
Rollup of 16 pull requests Successful merges: - #54755 (Documents reference equality by address (#54197)) - #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`) - #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer") - #54860 (Add doc comments about safest way to initialize a vector of zeros) - #54869 (Fix mobile docs) - #54891 (Fix tracking issue for Once::is_completed) - #54913 (doc fix: it's auto traits that make for automatic implementations) - #54920 (Fix handling of #[must_use] on unit and uninhabited types) - #54932 (A handful of random string-related improvements) - #54936 (impl Eq+Hash for TyLayout) - #54950 (std: Synchronize global allocator on wasm32) - #54956 ("(using ..." doesn't have the matching ")") - #54958 (add a macro for static (compile-time) assertions) - #54967 (Remove incorrect span for second label inner macro invocation) - #54983 (Fix slice's benchmarks) - #54989 (Fix spelling in the documentation to htmldocck.py) Failed merges: r? @ghost
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this pull request
Nov 5, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 6, 2018
…eflect-pr-54811, r=Mark-Simulacrum Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize This should have been part of PR rust-lang#54811 (my bad).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may have taken me three and a half years, but I'm following through on my "threat"
Fix #24840