Skip to content

turn std::oldmap into a wrapper around LinearMap - #5509

Closed
thestinger wants to merge 2 commits into
rust-lang:incomingfrom
thestinger:oldmap
Closed

thestinger wants to merge 2 commits into
rust-lang:incomingfrom
thestinger:oldmap

Conversation

@thestinger

Copy link
Copy Markdown
Contributor

The reasoning for doing it this way is that it's much easier to transition method-by-method to the Map API than trying to do the migration all at once.

I found an issue unrelated to my changes in one of the run-fail tests - if it uses LinearMap, it still fails but exits with 0. I xfailed it for now and opened an issue, because it's not caused by these changes.

@thestinger

Copy link
Copy Markdown
Contributor Author

A test fails because the crate hash depends on the order of the dependencies in a HashMap. The oldmap implementation always used 0, 0 as the SipHash keys so the order was (wrongly) consistent. They get sorted by name but this test case is using two crates with the same name (different version) so the order is non-deterministic. With 2 dependencies, it generates one of 2 possible hashes, with 3 dependencies it generates one of 6 and so on.

bors added a commit that referenced this pull request Mar 26, 2013
The reasoning for doing it this way is that it's much easier to transition method-by-method to the `Map` API than trying to do the migration all at once.

I found an issue unrelated to my changes in one of the run-fail tests - if it uses `LinearMap`, it still fails but exits with 0. I xfailed it for now and opened [an issue](#5512), because it's not caused by these changes.
@bors bors closed this Mar 26, 2013
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
…hiaskrgr

Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang#71414 rust-lang#5393

---

changelog: none
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 7, 2026
…async

Add libc direct tests for `fsync` and `fdatasync`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants