Skip to content

Small deriving-related cleanups - #5513

Merged
bors merged 2 commits into
incomingfrom
unknown repository
Mar 26, 2013
Merged

bors merged 2 commits into
incomingfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 23, 2013

Copy link
Copy Markdown

This removes some explicit implementations of Eq in favor of #[deriving(Eq)] and derives Clone for a few core types.

@ghost

ghost commented Mar 23, 2013

Copy link
Copy Markdown
Author

The test failures don't appear to have anything to do with this patch.

@thestinger

Copy link
Copy Markdown
Contributor

@apasel422: yeah, they're unrelated - incoming needs some tests fixed atm

@ghost

ghost commented Mar 25, 2013

Copy link
Copy Markdown
Author

I think that the test cases in question were fixed and that merging this can be attempted again.

bors added a commit that referenced this pull request Mar 26, 2013
This removes some explicit implementations of `Eq` in favor of `#[deriving(Eq)]` and derives `Clone` for a few core types.
@bors bors closed this Mar 26, 2013
@bors
bors merged commit 45677ee into rust-lang:incoming Mar 26, 2013
@ghost
ghost deleted the deriving branch March 26, 2013 11:27
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 2, 2020
fix clippy_dev exit status and make regex match again

changelog: none

Fixes rust-lang#5510

r? @phansch
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
5513: Try figure out correct workspace in vscode multi root workspace r=vsrs a=urbandove

the code to replace the root with the `${workspaceRoot}` arg breaks in multi root workspaces as it needs a qualifier `${workspaceRoot:workspaceName}`

This PR attempts to figure out the root workspace - and if it cant find it falls back to the first workspace

Co-authored-by: Urban Dove <urbandove80@gmail.com>
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants