use structured suggestions for nonexistent fields#57047
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 31, 2018
Merged
use structured suggestions for nonexistent fields#57047bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
killercup
reviewed
Dec 21, 2018
euclio
force-pushed
the
field-structured-suggestions
branch
from
c48ddf7 to
f81aa03
Compare
Collaborator
|
☔ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
approved these changes
Dec 26, 2018
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
You'll need to rebase to fix the merge conflict.
Left one wording nitpick, as we're trying to move away from the "did you mean" style.
estebank
added
S-waiting-on-author
euclio
force-pushed
the
field-structured-suggestions
branch
from
f81aa03 to
dfc326d
Compare
Contributor
Author
|
@estebank Rebased, and removed the "did you mean" language from the affected diagnostics. |
estebank
reviewed
Dec 31, 2018
| | | ||
| LL | let z = NonCopyable{ p: () }; //~ ERROR struct `NonCopyable` has no field named `p` | ||
| | ^ field does not exist - did you mean `0`? | ||
| | ^ help: a field with a similar name exists: `0` |
Contributor
There was a problem hiding this comment.
Not relevant to this PR It'd be nice to suggest the appropriate syntax here:
error[E0560]: struct `NonCopyable` has no field named `p`
--> $DIR/issue-4736.rs:4:26
|
LL | let z = NonCopyable{ p: () }; //~ ERROR struct `NonCopyable` has no field named `p`
| -------------^-----
| | |
| | field does not exist
| help: `NonCopyable` is a tuple struct, use the appropriate syntax: `NonCopyable(())`
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit dfc326d has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 31, 2018
use structured suggestions for nonexistent fields r? @estebank
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @estebank