Closed
Conversation
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Co-Authored-By: varkor <github@varkor.com>
There is no difference in the code/arguments, so go with the shorter name throughout the code.
MetaItem.span was always equivalent
Always the same as the passed MetaItem
…obody Add keywords item into the sidebar Fixes rust-lang#62939. cc @pravic screenshot of the result:  r? @QuietMisdreavus
Make "see issue" consistent Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search. r? @varkor
Account for `maybe_whole_expr` in range patterns Fixes rust-lang#63115 (fallout from rust-lang#62550). r? @petrochenkov
…chenkov Cleanup syntax::attr Mostly removing needless arguments to constructors r? @petrochenkov
…cramertj Remove redundant method with const variable resolution I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
cleanup StringReader fields reduce visibility and replace `Lrc<SourceFile>` with `start_pos`: the single bit we actually *need* from the file. r? @petrochenkov
Contributor
Author
|
@bors r+ p=6 rollup=never |
Collaborator
|
📌 Commit cb4c25b has been approved by |
Collaborator
|
⌛ Testing commit cb4c25b with merge 95a212a2461fd118dcd52773e554f4334ee17add... |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
maybe_whole_exprin range patterns #63122 (Account formaybe_whole_exprin range patterns)Failed merges:
r? @ghost