Skip to content

update miri#63922

Merged
bors merged 1 commit intorust-lang:masterfrom
RalfJung:miri
Aug 27, 2019
Merged

update miri#63922
bors merged 1 commit intorust-lang:masterfrom
RalfJung:miri

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 26, 2019 •
edited
Loading

Cc @oli-obk

Fixes #63843

@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 26, 2019

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 26, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2019
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 26, 2019

r=me I suppose but

Bash exited with code '1'.

not sure what's up with that error from Azure

@RalfJung
Copy link
Member Author

RalfJung commented Aug 26, 2019

Now without the getrandom changes.

@bors r=nikomatsakis p=1

@bors
Copy link
Collaborator

bors commented Aug 26, 2019

📌 Commit c706ed740e5745d6e0db5a823b027131ff20e287 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2019
@bors
Copy link
Collaborator

bors commented Aug 26, 2019

⌛ Testing commit c706ed740e5745d6e0db5a823b027131ff20e287 with merge 119539abb3b60326a46d4a60193bcc8f0f248b4f...

@rust-highfive

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Aug 27, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Aug 27, 2019

Updated Miri to fix build failure.

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

📌 Commit 22d9a1ce7716ce9551fc28cb71ddf2c63053b847 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2019
@bors
Copy link
Collaborator

bors commented Aug 27, 2019

⌛ Testing commit 22d9a1ce7716ce9551fc28cb71ddf2c63053b847 with merge fef409948aee2961b96a26b4496be650b4985a99...

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Aug 27, 2019 

2019-08-27T12:43:38.1469725Z the following dependencies have different features:
2019-08-27T12:43:38.1469861Z   getrandom 0.1.8 (registry+https://github.com/rust-lang/crates.io-index)
2019-08-27T12:43:38.1495969Z     `miri` additionally enabled features {} at "D:\\a\\1\\s\\build\\x86_64-pc-windows-gnu\\stage1-tools\\x86_64-pc-windows-gnu\\release\\deps\\libgetrandom-4754dc118ff8df3b.rlib"
2019-08-27T12:43:38.1517620Z     `cargo` additionally enabled features {"std"} at "D:\\a\\1\\s\\build\\x86_64-pc-windows-gnu\\stage1-tools\\x86_64-pc-windows-gnu\\release\\deps\\libgetrandom-ac194b7958ad050f.rlib"

Seems like we'll have to also enable the std feature for getrandom in Miri then. Odd.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 27, 2019

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

📌 Commit 98ad4ac has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2019
@bors
Copy link
Collaborator

bors commented Aug 27, 2019

⌛ Testing commit 98ad4ac with merge 53df91a...

bors added a commit that referenced this pull request Aug 27, 2019
@bors
Auto merge of #63922 - RalfJung:miri, r=nikomatsakis
53df91a 
update miri

Cc @oli-obk

Fixes #63843
@bors bors mentioned this pull request Aug 27, 2019
Closed
@bors
Copy link
Collaborator

bors commented Aug 27, 2019

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 53df91a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2019
@bors bors merged commit 98ad4ac into rust-lang:master Aug 27, 2019
@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 27, 2019

📣 Toolstate changed by #63922!

Tested on commit 53df91a.
Direct link to PR: #63922

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 27, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#63922!
d366d79 
Tested on commit rust-lang/rust@53df91a.
Direct link to PR: <rust-lang/rust#63922>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
@RalfJung RalfJung deleted the miri branch August 29, 2019 08:01
@safinaskar safinaskar mentioned this pull request Jun 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#63637

4 participants

@RalfJung @rust-highfive @nikomatsakis @bors