rustbuild: allow disabling deny(warnings) for bootstrap by Keruspe · Pull Request #63941 · rust-lang/rust

Keruspe · 2019-08-27T07:38:44Z

When deny-warnings is not specified or set to true, the behaviour is the same as before.
When deny-warnings is set to false, warnings are now allowed

Fixes #63911

rust-highfive · 2019-08-27T07:38:55Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

src/bootstrap/lib.rs

petrochenkov · 2019-08-27T09:32:27Z

r? @Mark-Simulacrum

src/bootstrap/bootstrap.py

src/bootstrap/lib.rs

Mark-Simulacrum

Modulo this comment and squashed commits r=me

src/bootstrap/lib.rs

When deny-warnings is not specified or set to true, the behaviour is the same as before. When deny-warnings is set to false, warnings are now allowed Fixes rust-lang#63911 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>

Keruspe · 2019-08-27T15:27:28Z

squashed

Mark-Simulacrum · 2019-08-27T15:28:50Z

@bors r+

Thanks!

bors · 2019-08-27T15:28:51Z

📌 Commit 935c1c8 has been approved by Mark-Simulacrum

rustbuild: allow disabling deny(warnings) for bootstrap When deny-warnings is not specified or set to true, the behaviour is the same as before. When deny-warnings is set to false, warnings are now allowed Fixes rust-lang#63911

Keruspe · 2019-08-29T09:30:21Z

@Mark-Simulacrum Do you think that it could be backported to 1.38 or should we do that downstream?

rustbuild: allow disabling deny(warnings) for bootstrap When deny-warnings is not specified or set to true, the behaviour is the same as before. When deny-warnings is set to false, warnings are now allowed Fixes rust-lang#63911

@ghost

Rollup of 7 pull requests Successful merges: - #63867 (resolve: Block expansion of a derive container until all its derives are resolved) - #63880 (Validation: check raw wide pointer metadata) - #63914 (ty: use Align for ReprOptions pack and align.) - #63941 (rustbuild: allow disabling deny(warnings) for bootstrap) - #63949 (Fix build src/libtest) - #63984 (Update rust-installer to limit memory use) - #63992 (Small improvement for Ord implementation of integers) Failed merges: r? @ghost

bors · 2019-08-29T15:01:43Z

⌛ Testing commit 935c1c8 with merge 7445622...

Mark-Simulacrum · 2019-08-29T15:09:01Z

We generally don't backport bootstrap changes so I would do so downstream.

emilyalbini · 2019-09-04T16:31:10Z

@bors r-

emilyalbini · 2019-09-04T16:31:56Z

@bors r- retry

Pkgsrc changes: * Remove patch which no longer applies (but what about RPATH?) * Adapt a few patches to changed files upstream. Upstream changes: Version 1.39.0 (2019-11-07) =========================== Language -------- - [You can now create `async` functions and blocks with `async fn`, `async move {}`, and `async {}` respectively, and you can now call `.await` on async expressions.][63209] - [You can now use certain attributes on function, closure, and function pointer parameters.][64010] These attributes include `cfg`, `cfg_attr`, `allow`, `warn`, `deny`, `forbid` as well as inert helper attributes used by procedural macro attributes applied to items. e.g. ```rust fn len( #[cfg(windows)] slice: &[u16], #[cfg(not(windows))] slice: &[u8], ) -> usize { slice.len() } ``` - [You can now take shared references to bind-by-move patterns in the `if` guards of `match` arms.][63118] e.g. ```rust fn main() { let array: Box<[u8; 4]> = Box::new([1, 2, 3, 4]); match array { nums // ---- `nums` is bound by move. if nums.iter().sum::<u8>() == 10 // ^------ `.iter()` implicitly takes a reference to `nums`. => { drop(nums); // ----------- Legal as `nums` was bound by move and so we have ownership. } _ => unreachable!(), } } ``` Compiler -------- - [Added tier 3\* support for the `i686-unknown-uefi` target.][64334] - [Added tier 3 support for the `sparc64-unknown-openbsd` target.][63595] - [rustc will now trim code snippets in diagnostics to fit in your terminal.] [63402] **Note** Cargo currently doesn't use this feature. Refer to [cargo#7315][cargo/7315] to track this feature's progress. - [You can now pass `--show-output` argument to test binaries to print the output of successful tests.][62600] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`Vec::new` and `String::new` are now `const` functions.][64028] - [`LinkedList::new` is now a `const` function.][63684] - [`str::len`, `[T]::len` and `str::as_bytes` are now `const` functions.][63770] - [The `abs`, `wrapping_abs`, and `overflowing_abs` numeric functions are now `const`.][63786] Stabilized APIs --------------- - [`Pin::into_inner`] - [`Instant::checked_duration_since`] - [`Instant::saturating_duration_since`] Cargo ----- - [You can now publish git dependencies if supplied with a `version`.] [cargo/7237] - [The `--all` flag has been renamed to `--workspace`.][cargo/7241] Using `--all` is now deprecated. Misc ---- - [You can now pass `-Clinker` to rustdoc to control the linker used for compiling doctests.][63834] Compatibility Notes ------------------- - [Code that was previously accepted by the old borrow checker, but rejected by the NLL borrow checker is now a hard error in Rust 2018.][63565] This was previously a warning, and will also become a hard error in the Rust 2015 edition in the 1.40.0 release. - [`rustdoc` now requires `rustc` to be installed and in the same directory to run tests.][63827] This should improve performance when running a large amount of doctests. - [The `try!` macro will now issue a deprecation warning.][62672] It is recommended to use the `?` operator instead. - [`asinh(-0.0)` now correctly returns `-0.0`.][63698] Previously this returned `0.0`. [62600]: rust-lang/rust#62600 [62672]: rust-lang/rust#62672 [63118]: rust-lang/rust#63118 [63209]: rust-lang/rust#63209 [63402]: rust-lang/rust#63402 [63565]: rust-lang/rust#63565 [63595]: rust-lang/rust#63595 [63684]: rust-lang/rust#63684 [63698]: rust-lang/rust#63698 [63770]: rust-lang/rust#63770 [63786]: rust-lang/rust#63786 [63827]: rust-lang/rust#63827 [63834]: rust-lang/rust#63834 [63927]: rust-lang/rust#63927 [63933]: rust-lang/rust#63933 [63934]: rust-lang/rust#63934 [63938]: rust-lang/rust#63938 [63940]: rust-lang/rust#63940 [63941]: rust-lang/rust#63941 [63945]: rust-lang/rust#63945 [64010]: rust-lang/rust#64010 [64028]: rust-lang/rust#64028 [64334]: rust-lang/rust#64334 [cargo/7237]: rust-lang/cargo#7237 [cargo/7241]: rust-lang/cargo#7241 [cargo/7315]: rust-lang/cargo#7315 [`Pin::into_inner`]: https://doc.rust-lang.org/std/pin/struct.Pin.html#method.into_inner [`Instant::checked_duration_since`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_duration_since [`Instant::saturating_duration_since`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.saturating_duration_since

rust-highfive assigned nikomatsakis Aug 27, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2019

Keruspe mentioned this pull request Aug 27, 2019

1.38 beta fails to bootstrap itself #63911

Closed

petrochenkov reviewed Aug 27, 2019

View reviewed changes

src/bootstrap/lib.rs Outdated Show resolved Hide resolved

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Aug 27, 2019

Mark-Simulacrum reviewed Aug 27, 2019

View reviewed changes

src/bootstrap/bootstrap.py Outdated Show resolved Hide resolved

src/bootstrap/lib.rs Outdated Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2019

Mark-Simulacrum reviewed Aug 27, 2019

View reviewed changes

src/bootstrap/lib.rs Outdated Show resolved Hide resolved

Keruspe force-pushed the warnings branch from e6d4946 to ac65c2d Compare August 27, 2019 15:26

Keruspe force-pushed the warnings branch from ac65c2d to 935c1c8 Compare August 27, 2019 15:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2019

Centril mentioned this pull request Aug 29, 2019

Rollup of 8 pull requests #63995

Closed

Centril mentioned this pull request Aug 29, 2019

Rollup of 7 pull requests #63996

Closed

Centril mentioned this pull request Aug 29, 2019

Rollup of 7 pull requests #63998

Merged

bors merged commit 935c1c8 into rust-lang:master Aug 29, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2019

Uh oh!

Conversation

Keruspe commented Aug 27, 2019

Uh oh!

rust-highfive commented Aug 27, 2019

Uh oh!

Uh oh!

petrochenkov commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Keruspe commented Aug 27, 2019

Uh oh!

Mark-Simulacrum commented Aug 27, 2019

Uh oh!

bors commented Aug 27, 2019

Uh oh!

Keruspe commented Aug 29, 2019

Uh oh!

bors commented Aug 29, 2019

Uh oh!

Mark-Simulacrum commented Aug 29, 2019

Uh oh!

emilyalbini commented Sep 4, 2019

Uh oh!

emilyalbini commented Sep 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Mark-Simulacrum left a comment •

edited

Loading