Skip to content

Add queries for LocalDefId <-> HirId conversion#70039

Closed
Zoxc wants to merge 1 commit intorust-lang:masterfrom
Zoxc:track-hir-id
Closed

Add queries for LocalDefId <-> HirId conversion#70039
Zoxc wants to merge 1 commit intorust-lang:masterfrom
Zoxc:track-hir-id

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 16, 2020

This should fix #62649.

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 16, 2020

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 16, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 16, 2020

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Mar 16, 2020

⌛ Trying commit 317febbdf7c843869dc236556a5359384c6704c9 with merge 0610946ef6f75f07e1a2f35658163efef75a619b...

@bors
Copy link
Collaborator

bors commented Mar 16, 2020

☀️ Try build successful - checks-azure
Build commit: 0610946ef6f75f07e1a2f35658163efef75a619b (0610946ef6f75f07e1a2f35658163efef75a619b)

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 16, 2020

Queued 0610946ef6f75f07e1a2f35658163efef75a619b with parent 8e6de32, future comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 16, 2020

Finished benchmarking try commit 0610946ef6f75f07e1a2f35658163efef75a619b, comparison URL.

@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 17, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 17, 2020

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Mar 17, 2020

⌛ Trying commit f509a97f47f07c684bf37a0f87235bacbb573540 with merge cf9edb09c040cbf50cba9a89d38f985e35fd421e...

@bors
Copy link
Collaborator

bors commented Mar 17, 2020

☀️ Try build successful - checks-azure
Build commit: cf9edb09c040cbf50cba9a89d38f985e35fd421e (cf9edb09c040cbf50cba9a89d38f985e35fd421e)

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 17, 2020

Queued cf9edb09c040cbf50cba9a89d38f985e35fd421e with parent 5e9ebf4, future comparison URL.

@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 17, 2020

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned varkor Mar 17, 2020
@Zoxc Zoxc force-pushed the track-hir-id branch 2 times, most recently from fd5fa84 to 2885ae8 Compare March 18, 2020 14:11
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 18, 2020

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Mar 18, 2020

⌛ Trying commit 2885ae83ff3b1ffae467fd0057bb268d479d191a with merge 3b97f7174ec8722ef3c46993f9f5f98e1f54c25c...

@bors
Copy link
Collaborator

bors commented Mar 18, 2020

💥 Test timed out

@bors
Copy link
Collaborator

bors commented Mar 19, 2020

☔ The latest upstream changes (presumably #66131) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc changed the title [WIP] Add queries for DefIndex <-> HirId conversion [WIP] Add queries for LocalDefId <-> HirId conversion Mar 19, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 19, 2020

@bors try

@bors
Copy link
Collaborator

bors commented Mar 19, 2020

⌛ Trying commit e83a7549fb7dc8e2b695c4efb592228a42d41726 with merge dfe964665105bc34a303b7e481ae4bff0376cf27...

@bors bors mentioned this pull request Mar 19, 2020
Merged
@bors
Copy link
Collaborator

bors commented Mar 19, 2020

☀️ Try build successful - checks-azure
Build commit: dfe964665105bc34a303b7e481ae4bff0376cf27 (dfe964665105bc34a303b7e481ae4bff0376cf27)

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 19, 2020

Queued dfe964665105bc34a303b7e481ae4bff0376cf27 with parent 3c6f982, future comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Mar 19, 2020

Finished benchmarking try commit dfe964665105bc34a303b7e481ae4bff0376cf27, comparison URL.

@Zoxc Zoxc changed the title [WIP] Add queries for LocalDefId <-> HirId conversion Add queries for LocalDefId <-> HirId conversion Mar 19, 2020
@bors
Copy link
Collaborator

bors commented Mar 22, 2020

☔ The latest upstream changes (presumably #70246) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 28, 2020

☔ The latest upstream changes (presumably #70483) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 30, 2020

☔ The latest upstream changes (presumably #70536) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Apr 10, 2020

Closing this pull request as Zoxc is stepping back from compiler development; see rust-lang/team#316.

@Aaron1011 Aaron1011 mentioned this pull request Aug 17, 2020
Closed
Aaron1011 added a commit to Aaron1011/rust that referenced this pull request Aug 20, 2020
@Aaron1011
Query-ify LocalDefId <-> HirId conversion
69cea9c 
Based on PR rust-lang#70039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddyb eddyb

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE in incr comp after s/trait/struct/: src/librustc/dep_graph/graph.rs:688: DepNode Hir(...) should have been pre-allocated but wasn't.

8 participants

@Zoxc @rust-highfive @rust-timer @bors @nikomatsakis @eddyb @JohnCSimon @varkor