Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup Thanks! |
Collaborator
|
📌 Commit 61ed813 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 16, 2020
…Simulacrum Add some regression tests Closes rust-lang#24843 Closes rust-lang#28575 Closes rust-lang#54067 Closes rust-lang#67893 Closes rust-lang#68813 I'm not sure who's the best person to ask to review since Centril is taking a break now.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 16, 2020
…Simulacrum Add some regression tests Closes rust-lang#24843 Closes rust-lang#28575 Closes rust-lang#54067 Closes rust-lang#67893 Closes rust-lang#68813 I'm not sure who's the best person to ask to review since Centril is taking a break now.
|
failed in rollup @bors r- |
bors
added
S-waiting-on-author
Member
Author
|
I think the cause is the same as #67543 (comment), I'll figure out the targets that should be skipped for now. |
Member
Author
|
@Mark-Simulacrum So, adding |
Member
|
Ah yeah let's go with that for now |
JohnTitor
force-pushed
the
regression-tests
branch
from
61ed813 to
a6855b9
Compare
Collaborator
|
📌 Commit a6855b9 has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70578 (Add long error explanation for E0657) - rust-lang#70910 (Hides default fns inside Fuse impl to avoid exposing it to any crate) - rust-lang#71164 (reword Miri validity errors: undefined -> uninitialized) - rust-lang#71182 (Add some regression tests) - rust-lang#71206 (Miri error messages: avoid try terminology) - rust-lang#71220 (Dogfood or_patterns in the standard library) - rust-lang#71225 (Fix typo in Default trait docs: Provides -> Provide) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24843
Closes #28575
Closes #54067
Closes #66868
Closes #67893
Closes #68813