rustc_target: Avoid an inappropriate use of post_link_objects#72304
rustc_target: Avoid an inappropriate use of post_link_objects#72304bors merged 1 commit intorust-lang:masterfrom
post_link_objects#72304Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
So I think this change is acceptable |
|
Related rust-lang/llvm-project#57 |
|
r=me presuming folks say this is works for them, I suppose, but the truth is I don't know anything about this target. Is there a better reviewer out there? |
There was a problem hiding this comment.
r=me presuming folks say this is works for them, I suppose, but the truth is I don't know anything about this target. Is there a better reviewer out there?
could you please add target_vendor = "fortanix" along with the target_env check? thanks! background: #57231
petrochenkov
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #71769) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r=nikomatsakis,jethrogb,dingelish |
|
📌 Commit ed1297c has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#71607 (clarify interaction of pin drop guarantee and panics) - rust-lang#72125 (remove broken link) - rust-lang#72133 (Add target thumbv7a-uwp-windows-msvc) - rust-lang#72304 (rustc_target: Avoid an inappropriate use of `post_link_objects`) - rust-lang#72309 (Some renaming and minor refactoring for `NativeLibraryKind`) - rust-lang#72438 (Enable ARM TME (Transactional Memory Extensions)) Failed merges: r? @ghost
6 participants
It isn't supposed to be used for linking libraries.
Also linking libunwind unconditionally (and not together with the
src/libunwindcrate) is suspicious.@jethrogb @VardhanThigle
Could you verify that it works as expected?