Conversation
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| /// [slice]: ../../std/primitive.slice.html | ||
| /// [trait object]: ../../book/ch17-02-trait-objects.html | ||
| /// [extern type]: ../../unstable-book/language-features/extern-types.html | ||
| /// [`size_of_val`]: ../../core/mem/fn.size_of_val.html |
There was a problem hiding this comment.
Is this needed? https://doc.rust-lang.org/nightly/core/mem/fn.size_of_val.html already correctly links to size_of_val
There was a problem hiding this comment.
This is in size_of_val_raw though? I do not understand the question.
There was a problem hiding this comment.
I meant that https://doc.rust-lang.org/nightly/core/mem/fn.size_of_val_raw.html correctly links the size_of_val 😅
There was a problem hiding this comment.
Oh... that's weird, I just saw it with a broken link somewhere... let me see if I can find that again.
There was a problem hiding this comment.
Ah, the link is broken here:
https://doc.rust-lang.org/nightly/std/mem/fn.size_of_val_raw.html
Sounds like a rustdoc bug then? Cc @rust-lang/rustdoc
There was a problem hiding this comment.
It's #65983. The intra-doc link feature isn't ready for use in std yet.
There was a problem hiding this comment.
Okay, seems like my patch makes sense then as it avoids using that feature.
Co-authored-by: Bastian Kauschke <[email protected]>
|
@bors r+ rollup |
|
📌 Commit cb8c94c has been approved by |
bors
added
S-waiting-on-bors
…aster add missing doc links The doc comments contain ``[`size_of_val`]`` but the link target was missing.
…aster add missing doc links The doc comments contain ``[`size_of_val`]`` but the link target was missing.
…aster add missing doc links The doc comments contain ``[`size_of_val`]`` but the link target was missing.
…arth Rollup of 12 pull requests Successful merges: - rust-lang#72771 (Warn if linking to a private item) - rust-lang#72937 (Fortanix SGX target libunwind build process changes) - rust-lang#73485 (Perform obligation deduplication to avoid buggy `ExistentialMismatch`) - rust-lang#73529 (Add liballoc impl SpecFromElem for i8) - rust-lang#73579 (add missing doc links) - rust-lang#73627 (Shortcuts for min/max on double-ended BTreeMap/BTreeSet iterators) - rust-lang#73691 (Bootstrap: detect Windows based on sys.platform) - rust-lang#73694 (Document the Self keyword) - rust-lang#73718 (Document the super keyword) - rust-lang#73728 (Document some invariants correctly/more) - rust-lang#73738 (Remove irrelevant comment) - rust-lang#73765 (Remove blank line) Failed merges: r? @ghost
8 participants
The doc comments contain
[`size_of_val`]but the link target was missing.