Skip to content

Add docs for BasicBlock #76732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
Sep 20, 2020
Merged

Add docs for BasicBlock #76732

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd79ed4
Add docs for `BasicBlock`
camelid Sep 15, 2020
a872ec4
Clarify how branching works in a CFG
camelid Sep 15, 2020
c051f61
Improve wording
camelid Sep 15, 2020
57eb29c
Update based on review suggestions
camelid Sep 16, 2020
451f7f6
Use relative link instead of absolute
camelid Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions compiler/rustc_middle/src/mir/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,6 +1076,19 @@ pub struct VarDebugInfo<'tcx> {
// BasicBlock

rustc_index::newtype_index! {
/// The unit of the MIR [control-flow graph][CFG].
Comment thread
camelid marked this conversation as resolved.
Outdated
///
/// There is no branching (e.g., `if`s, function calls, etc.) within a basic block, which makes
Comment thread
RalfJung marked this conversation as resolved.
Outdated
Comment thread
camelid marked this conversation as resolved.
Outdated
/// it easier to do [data-flow analyses] and optimizations. Basic blocks consist of a series of
/// [statements][`Statement`], ending with a [terminator][`Terminator`]. Basic blocks can have
/// multiple predecessors and successors.
///
/// Read more about basic blocks in the [rustc-dev-guide][guide-mir].
Comment thread
camelid marked this conversation as resolved.
///
/// [CFG]: https://rustc-dev-guide.rust-lang.org/appendix/background.html#cfg
/// [data-flow analyses]:
/// https://rustc-dev-guide.rust-lang.org/appendix/background.html#what-is-a-dataflow-analysis
/// [guide-mir]: https://rustc-dev-guide.rust-lang.org/mir/
pub struct BasicBlock {
derive [HashStable]
DEBUG_FORMAT = "bb{}",
Expand All @@ -1092,6 +1105,7 @@ impl BasicBlock {
///////////////////////////////////////////////////////////////////////////
// BasicBlockData and Terminator

/// See [`BasicBlock`] for documentation on what basic blocks are at a high level.
#[derive(Clone, Debug, TyEncodable, TyDecodable, HashStable, TypeFoldable)]
pub struct BasicBlockData<'tcx> {
/// List of statements in this block.
Expand Down