Only compute Obligation cache_key once in register_obligation_at#84923
Only compute Obligation cache_key once in register_obligation_at#84923bors merged 1 commit intorust-lang:masterfrom
cache_key once in register_obligation_at#84923Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 4bd5505 with merge 8cb096cd1b5a7231a55f4ce1e96f365e0c17fb78... |
|
☀️ Try build successful - checks-actions |
|
Queued 8cb096cd1b5a7231a55f4ce1e96f365e0c17fb78 with parent dc5f2cd, future comparison URL. |
petrochenkov
removed
the
S-waiting-on-review
|
Finished benchmarking try commit (8cb096cd1b5a7231a55f4ce1e96f365e0c17fb78): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
added
S-waiting-on-review
|
Perf looks like noise :/ |
|
Still makes sense as a minor cleanup. |
|
📌 Commit 4bd5505 has been approved by |
bors
added
S-waiting-on-bors
…chenkov Only compute Obligation `cache_key` once in `register_obligation_at`
…chenkov Only compute Obligation `cache_key` once in `register_obligation_at`
…chenkov Only compute Obligation `cache_key` once in `register_obligation_at`
Rollup of 8 pull requests Successful merges: - rust-lang#83507 (Implement RFC 2951: Native link modifiers) - rust-lang#84328 (Stablize {HashMap,BTreeMap}::into_{keys,values}) - rust-lang#84712 (Simplify chdir implementation and minimize unsafe block) - rust-lang#84851 (:arrow_up: rust-analyzer) - rust-lang#84923 (Only compute Obligation `cache_key` once in `register_obligation_at`) - rust-lang#84945 (E0583: Include secondary path in error message) - rust-lang#84949 (Fix typo in `MaybeUninit::array_assume_init` safety comment) - rust-lang#84950 (Revert PR 83866) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| .error_cache | ||
| .get(&obligation_tree_id) | ||
| .map(|errors| errors.contains(&obligation.as_cache_key())) | ||
| .map(|errors| errors.contains(&cache_key)) |
There was a problem hiding this comment.
this can be v.key(), allowing the clone on line 345 to be elided.
8 participants
No description provided.