Use HTTPS links where possible by syvb · Pull Request #86586 · rust-lang/rust

syvb · 2021-06-23T20:36:24Z

While looking at #86583, I wondered how many other (insecure) HTTP links were in rustc. This changes most other http links to https. While most of the links are in comments or documentation, there are a few other HTTP links that are used by CI that are changed to HTTPS.

Notes:

I didn't change any to or in licences
Some links don't support HTTPS :(
Some http links were dead, in those cases I upgraded them to their new places (all of which used HTTPS)

rust-highfive · 2021-06-23T20:36:27Z

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

rust-highfive · 2021-06-23T20:36:28Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

compiler/rustc_target/src/abi/call/msp430.rs

src/test/ui/nullable-pointer-iotareduction.rs

petrochenkov · 2021-06-23T22:13:59Z

LGTM, although I obviously didn't check whether all the links are accessible.

petrochenkov · 2021-06-24T08:57:19Z

@bors r+

bors · 2021-06-24T08:57:21Z

📌 Commit 157898e has been approved by petrochenkov

…henkov Use HTTPS links where possible While looking at rust-lang#86583, I wondered how many other (insecure) HTTP links were in `rustc`. This changes most other `http` links to `https`. While most of the links are in comments or documentation, there are a few other HTTP links that are used by CI that are changed to HTTPS. Notes: - I didn't change any to or in licences - Some links don't support HTTPS :( - Some `http` links were dead, in those cases I upgraded them to their new places (all of which used HTTPS)

bors · 2021-06-25T03:59:41Z

⌛ Testing commit 157898e with merge 3d991178fe4bcc8ea8153cd15a311bc9f8ece22e...

bors · 2021-06-25T04:06:26Z

💔 Test failed - checks-actions

petrochenkov · 2021-06-25T08:28:02Z

CI is unable to download from https://gcc.gnu.org/pub/gcc/infrastructure/mpfr-2.4.2.tar.bz2

--2021-06-25 04:05:16--  https://gcc.gnu.org/pub/gcc/infrastructure/mpfr-2.4.2.tar.bz2
Resolving gcc.gnu.org... 8.43.85.97, 2620:52:3:1:0:246e:9693:128c
Connecting to gcc.gnu.org|8.43.85.97|:443... connected.
OpenSSL: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
Unable to establish SSL connection.

dns2utf8 · 2021-06-25T09:09:49Z

On the mailinglist from 2015 there was a discussion about including TLS 1.2 in Debian 6 (the image we are using):
https://lists.debian.org/debian-lts/2015/02/msg00012.html

The host gcc.gnu.org supports TLSv1.2 only:
https://www.ssllabs.com/ssltest/analyze.html?d=gcc.gnu.org&s=8.43.85.97&hideResults=on&ignoreMismatch=on

Where AWS supports TLS 1.0 to 1.3 the old image can use 1.1:
https://www.ssllabs.com/ssltest/analyze.html?d=ci%2dcaches.rust%2dlang.org&s=65.8.17.76&latest

Should we update it to Debian 7 because TLS 1.2 support will not happen and the LTS support has ended in 2016?

petrochenkov · 2021-06-25T10:39:16Z

Should we update it to Debian 7 because TLS 1.2 support will not happen and the LTS support has ended in 2016?

Maybe, but certainly not in this PR.
If changing http to https doesn't "just work" and require infra tweaks in some cases, then those changes and tweaks need to go to a separate PR (probably assigned to Mark-Simulacrum).

This is needed as they are built on a long-outdated Debian version. :(

petrochenkov · 2021-06-26T08:24:25Z

@bors r+

bors · 2021-06-26T08:24:27Z

📌 Commit 3da037f has been approved by petrochenkov

bors · 2021-06-26T08:24:36Z

⌛ Testing commit 3da037f with merge 4819719...

bors · 2021-06-26T10:52:10Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4819719 to master...

rust-highfive · 2021-06-26T10:52:36Z

📣 Toolstate changed by #86586!

Tested on commit 4819719.
Direct link to PR: #86586

🎉 rls on linux: test-fail → test-pass (cc @Xanewok).

@Xanewok

Tested on commit rust-lang/rust@4819719. Direct link to PR: <rust-lang/rust#86586> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok).

Revert "Download the GCC sources insecurely" This reverts commit 3da037f. This workaround was added after TLS problems with Debian 6 were noted in <rust-lang#86586 (comment)>, but we should be well past that since rust-lang#95026, where our oldest images are now based on CentOS 7.

Revert "Download the GCC sources insecurely" This reverts commit 3da037f. This workaround was added after TLS problems with Debian 6 were noted in <rust-lang/rust#86586 (comment)>, but we should be well past that since #95026, where our oldest images are now based on CentOS 7.

Use HTTPS links where possible

bdfcb88

rust-highfive assigned petrochenkov Jun 23, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2021

petrochenkov reviewed Jun 23, 2021

View reviewed changes

compiler/rustc_target/src/abi/call/msp430.rs Outdated Show resolved Hide resolved

src/test/ui/nullable-pointer-iotareduction.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2021

Point to the updated version of some dead links

157898e

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2021

m-ou-se mentioned this pull request Jun 24, 2021

Rollup of 6 pull requests #86601

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2021

This comment has been minimized.

Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2021

Download the GCC sources insecurely

3da037f

This is needed as they are built on a long-outdated Debian version. :(

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 26, 2021

bors merged commit 4819719 into rust-lang:master Jun 26, 2021

rustbot added this to the 1.55.0 milestone Jun 26, 2021

bors mentioned this pull request Jun 26, 2021

Replace per-target ABI denylist with an allowlist #86231

Merged

cuviper mentioned this pull request Apr 25, 2023

Revert "Download the GCC sources insecurely" #110784

Merged

Uh oh!

Conversation

syvb commented Jun 23, 2021

Uh oh!

rust-highfive commented Jun 23, 2021

Uh oh!

rust-highfive commented Jun 23, 2021

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jun 23, 2021

Uh oh!

petrochenkov commented Jun 24, 2021

Uh oh!

bors commented Jun 24, 2021

Uh oh!

bors commented Jun 25, 2021

Uh oh!

bors commented Jun 25, 2021

Uh oh!

This comment has been minimized.

petrochenkov commented Jun 25, 2021

Uh oh!

dns2utf8 commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Jun 26, 2021

Uh oh!

bors commented Jun 26, 2021

Uh oh!

bors commented Jun 26, 2021

Uh oh!

bors commented Jun 26, 2021

Uh oh!

rust-highfive commented Jun 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dns2utf8 commented Jun 25, 2021 •

edited

Loading

petrochenkov commented Jun 25, 2021 •

edited

Loading