Skip to content

switch Drop to &mut self - #9244

Merged
bors merged 1 commit into
rust-lang:masterfrom
thestinger:drop
Sep 17, 2013
Merged

bors merged 1 commit into
rust-lang:masterfrom
thestinger:drop

Conversation

@thestinger

Copy link
Copy Markdown
Contributor

This doesn't close any bugs as the goal is to convert the parameter to by-value, but this is a step towards being able to make guarantees about &T pointers (where T is Freeze) to LLVM.

Comment thread src/libstd/rt/uv/uvio.rs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this transmute is no longer necessary with this change? Also true for a lot of other lines below.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, missed that one.

bors added a commit that referenced this pull request Sep 17, 2013
This doesn't close any bugs as the goal is to convert the parameter to by-value, but this is a step towards being able to make guarantees about `&T` pointers (where T is Freeze) to LLVM.
@bors bors closed this Sep 17, 2013
@bors
bors merged commit 4e161a4 into rust-lang:master Sep 17, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 28, 2022
Fix ICE in `question_mark`

fixes rust-lang#9242
changelog: [`question_mark`](https://rust-lang.github.io/rust-clippy/master/#question_mark): Fix ICE on zero field tuple structs
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
9244: feat: Make block-local trait impls work r=flodiebold a=flodiebold

As long as either the trait or the implementing type are defined in the same block.

CC rust-lang#8961

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants