Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
|
||
| // build-pass | ||
|
|
||
| // edition:2018 |
There was a problem hiding this comment.
I'm not sure we parse these (at least yet -- unless we already merged the compiletest PR Pietro was working on here)?
I'd rather they be at the top of the file regardless.
There was a problem hiding this comment.
We have many other such cases in our test suite. The comments only get ignored after the first item, possibly even allowed after use statements.
| @@ -0,0 +1,21 @@ | |||
| #![feature(type_alias_impl_trait)] | |||
|
|
|||
| // edition:2018 | |||
There was a problem hiding this comment.
Similarly, I think this probably should be at the top of the file, I'm not sure it gets picked up by current compiletest otherwise.
|
r=me with nits fixed |
Mark-Simulacrum
added
S-waiting-on-author
|
@bors r+ I took a look at the compiletest parsing code, looks like we stop at "fn" or "mod", so seems okay. |
|
📌 Commit 52de679 has been approved by |
bors
added
S-waiting-on-bors
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#96336 (Link to correct `as_mut` in docs for `pointer::as_ref`) - rust-lang#96586 (Add aliases for std::fs::canonicalize) - rust-lang#96667 (Add regression test) - rust-lang#96671 (Remove hard links from `env::current_exe` security example) - rust-lang#96726 (Add regression and bug tests) - rust-lang#96756 (Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles) - rust-lang#96757 (Don't constantly rebuild clippy on `x test src/tools/clippy`.) - rust-lang#96769 (Remove `adx_target_feature` feature from active features list) - rust-lang#96777 (Make the test `check-pass` not to produce a JSON file) - rust-lang#96822 (Enforce quote rule for JS source code) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 participants
fixes #69785
This issue seems to have been fixed in the meantime.