Move check-bootstrap from a makefile rule to test::Bootstrap#96689
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
Author
|
(Force push was a squash) |
bjorn3
reviewed
May 4, 2022
bjorn3
reviewed
May 4, 2022
bjorn3
reviewed
May 4, 2022
Author
|
I..have to say, you're really quick at reviewing these, I just committed 😂 |
This comment has been minimized.
This comment has been minimized.
jyn514
approved these changes
May 4, 2022
Member
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Lgtm with CI passing :) thanks for working on this!
Member
|
r=me with commits squashed |
Author
|
@Mark-Simulacrum Squashed 👍🏻 |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 72d2d6a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (8fbd92d): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96688