Format try blocks more similarly as blocks

[ia0]

When using a normal block as the last argument of a function, formatting is compact:

    let _ = qux(x, {
        foo();
        bar();
    });

But not for try blocks:

    let _ = qux(
        x,
        try {
            foo();
            bar();
        },
    );

Ideally, I would expect:

    let _ = qux(x, try {
        foo();
        bar();
    });

Is this behavior intended or accidental? If it is intended what's the rationale? And could it be made customizable?

[ytmimi]

@ia0 I think this was just missed here because of the default _ => false.

try blocks are still unstable, right? If that's the case then this should be a pretty simple change to allow ast::ExprKind::TryBlock to overflow.

I see you've also created rust-lang/rust#152311. Do we want to allow Heterogeneous try blocks to also overflow?

[ia0]

I think this was just missed here because of the default _ => false.

Thanks for finding the root cause!

try blocks are still unstable, right?

Yes.

Do we want to allow Heterogeneous try blocks to also overflow?

My personal opinion is yes, but I have no authority. Let me ask for advice on the try blocks Zulip chat.

[ia0]

By the way, here's the Zulip thread: #t-style > Should try blocks overflow expr?. I didn't get an answer yet, I'm going to mention this question in rust-lang/rust#152311 since it's relevant (even though there doesn't seem to be documentation in the style guide about overflowed expr).

[joshtriplett]

@ia0 I would expect try blocks to behave like any other block here, with respect to overflow like this.

[ia0]

@ia0 I would expect try blocks to behave like any other block here, with respect to overflow like this.

Cool, thanks!

@ytmimi do you want to do it? Otherwise I can write a PR tomorrow.