try_from_into.rs: Improve slice implementation#2317
Open
EugenDueck wants to merge 1 commit intorust-lang:mainfrom
Open
try_from_into.rs: Improve slice implementation#2317EugenDueck wants to merge 1 commit intorust-lang:mainfrom
EugenDueck wants to merge 1 commit intorust-lang:mainfrom
Conversation
Using pattern matching, we can reduce four bound checks to just one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves readability. In terms of performance, it probably doesn't matter, because the multiple bounds checks in the original are likely to get optimized away.