Merged
Conversation
bytesnake
reviewed
Mar 17, 2021
Member
bytesnake
left a comment
bytesnake
left a comment
There was a problem hiding this comment.
I did a first round of review on the PR 👍
|
|
||
| #[cfg(test)] | ||
| mod test { | ||
| use super::*; |
Member
There was a problem hiding this comment.
the tests are currently only checking that the fitting process runs without error
Member
Author
There was a problem hiding this comment.
I think transform and predict were at least covered but I guess I can add some tests checking that we get the same results as scikit-learn.
Member
Author
|
Nothing to add on my side... Well, after this first round! 😅 |
bytesnake
reviewed
Mar 19, 2021
| }; | ||
| } | ||
|
|
||
| // Prediction values were checked against scikit-learn 0.24.1 |
bytesnake
approved these changes
Mar 19, 2021
Member
bytesnake
left a comment
bytesnake
left a comment
There was a problem hiding this comment.
thanks again for all the work! I will add a small example to the website as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements PLS methods in a new workspace member
linfa-pls.This is a straightforward port of scikit-learn 0.24 cross decomposition PLS code.